Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Reset subtreeFlags in resetWorkInProgress #20948

Merged
merged 2 commits into from
Mar 7, 2021

Commits on Mar 5, 2021

  1. Add failing regression test

    Based on facebook#20932
    
    Co-Authored-By: Dan Abramov <dan.abramov@gmail.com>
    acdlite and gaearon committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    80076d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Reset subtreeFlags in resetWorkInProgress

    Alternate fix to facebook#20942
    
    There was already a TODO to make this change, but at the time I left it,
    I couldn't think of a way that it would actually cause a bug, and I was
    hesistant to change something without fully understanding the
    ramifications. This was during a time when we were hunting down a
    different bug, so we were especially risk averse.
    
    What I should have done in retrospect is put the change behind a flag
    and tried rolling it out once the other bug had been flushed out.
    
    OTOH, now we have a regression test, which wouldn't have otherwise, and
    the bug it caused rarely fired in production.
    acdlite committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    5daa2cf View commit details
    Browse the repository at this point in the history