Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toMatchInlineSnapshot for dehydrated values #20618

Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 19, 2021

Summary

There may be other places where we want to use the serializer. I only reverted 9fd6735 (#20548) and tried to fix yarn test-build-devtools

Test Plan

  • CI green

@sizebot
Copy link

sizebot commented Jan 19, 2021

Comparing: 1214b30...56fcc69

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.49 kB 122.49 kB = 39.30 kB 39.30 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.06 kB 129.06 kB = 41.39 kB 41.39 kB
facebook-www/ReactDOM-prod.classic.js = 412.33 kB 412.33 kB = 76.19 kB 76.19 kB
facebook-www/ReactDOM-prod.modern.js = 400.38 kB 400.38 kB = 74.31 kB 74.31 kB
facebook-www/ReactDOMForked-prod.classic.js = 412.33 kB 412.33 kB = 76.19 kB 76.19 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 56fcc69

@sizebot
Copy link

sizebot commented Jan 19, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against ad46678

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad46678:

Sandbox Source
React Configuration

@eps1lon eps1lon marked this pull request as ready for review January 19, 2021 11:46
@eps1lon eps1lon changed the title Use toMatchInlineSnapshot for dehydrated values DO NOT MERGE Use toMatchInlineSnapshot for dehydrated values Jan 19, 2021
@eps1lon eps1lon force-pushed the devtools-replace-cache-serialize-dehydrated branch from d3b923b to ad46678 Compare January 19, 2021 19:09
@eps1lon eps1lon force-pushed the devtools-replace-cache-serialize-dehydrated branch from ad46678 to 9d8854e Compare April 8, 2021 09:22
@eps1lon eps1lon marked this pull request as draft April 8, 2021 09:36
@eps1lon eps1lon force-pushed the devtools-replace-cache-serialize-dehydrated branch 4 times, most recently from bb557cd to 634c8b6 Compare April 8, 2021 11:18
@eps1lon eps1lon changed the title DO NOT MERGE Use toMatchInlineSnapshot for dehydrated values Use toMatchInlineSnapshot for dehydrated values Apr 8, 2021
@eps1lon eps1lon force-pushed the devtools-replace-cache-serialize-dehydrated branch from 634c8b6 to 0be6c2f Compare April 8, 2021 11:35
@eps1lon eps1lon marked this pull request as ready for review April 8, 2021 11:51
@eps1lon eps1lon requested a review from bvaughn April 8, 2021 11:51
@bvaughn
Copy link
Contributor

bvaughn commented Apr 8, 2021

Merge conflicts~

Same reason why jest can fail with "could not find all inline snapshots".
Since we don't need "done()" on async tests we can safely remove it.
@eps1lon eps1lon force-pushed the devtools-replace-cache-serialize-dehydrated branch from 0be6c2f to ee699c0 Compare April 8, 2021 17:04
@eps1lon
Copy link
Collaborator Author

eps1lon commented Apr 8, 2021

Merge conflicts~

@bvaughn Resolved

@eps1lon eps1lon requested a review from bvaughn April 25, 2021 18:21
@bvaughn bvaughn merged commit 84b9162 into facebook:master Apr 26, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Apr 26, 2021

Thanks!

@bvaughn bvaughn deleted the devtools-replace-cache-serialize-dehydrated branch April 26, 2021 16:30
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants