Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DEV-mode warnings in devtools UI #20463

Merged
merged 104 commits into from
Dec 22, 2020
Merged

Expose DEV-mode warnings in devtools UI #20463

merged 104 commits into from
Dec 22, 2020

Commits on Dec 14, 2020

  1. STASH incomplete feature (no UI, some TODOs)

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    443831b View commit details
    Browse the repository at this point in the history

  2. Add UI

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    1a34269 View commit details
    Browse the repository at this point in the history

  3. Add view for errors/warnings in inspected element

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6cc7fdb View commit details
    Browse the repository at this point in the history

  4. Serialize args

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    59ddad1 View commit details
    Browse the repository at this point in the history

  5. Ignore component stacks in inline errors view

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    9372221 View commit details
    Browse the repository at this point in the history

  6. Add icons for warnings and errors

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    34500ea View commit details
    Browse the repository at this point in the history

  7. Cleanup unused console logs

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    962f08c View commit details
    Browse the repository at this point in the history

  8. Fix flow issues

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    3104b1e View commit details
    Browse the repository at this point in the history

  9. Implement clear(all,byComponent,byErrorOrWarning)

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    cf3f212 View commit details
    Browse the repository at this point in the history

  10. Expand showcase with error and warn/error mix

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    5b3fb89 View commit details
    Browse the repository at this point in the history

  11. Fix missing color error background message

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    d2c8e33 View commit details
    Browse the repository at this point in the history

  12. Highlight elements in tree 

    Before we had to vertically and horizontally scan.
By coloring the rows, vertically is sufficient.
Though I'm having a hard time in light mode. Dark mode is better.
    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    dc92fef View commit details
    Browse the repository at this point in the history

  13. Better spacing for error/warning badges

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    1533583 View commit details
    Browse the repository at this point in the history

  14. BROKEN Implement walking through elements with warning/errors

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    4b46d94 View commit details
    Browse the repository at this point in the history

  15. Remove nullish coalescing which is only used in the scheduling profiler

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    ae89ee8 View commit details
    Browse the repository at this point in the history

  16. Bail out if we have no errors/warnings

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6e41fc1 View commit details
    Browse the repository at this point in the history

  17. Hide inline errors toolbar if there are now errors at all

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    8de25ff View commit details
    Browse the repository at this point in the history

  18. Remove outdated todo

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    3560c40 View commit details
    Browse the repository at this point in the history

  19. Add keys for error/warn messages

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    45f7562 View commit details
    Browse the repository at this point in the history

  20. Diff cleanup

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    1dafc3b View commit details
    Browse the repository at this point in the history

  21. Fix flow errors due to missing type narrowing capabilities

    @eps1lon
    eps1lon committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e3e95fb View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Match UI of Search

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    2aafbdf View commit details
    Browse the repository at this point in the history

  2. Match UX of Search

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    64ad2e2 View commit details
    Browse the repository at this point in the history

  3. Resolve todo about args copying

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    826993e View commit details
    Browse the repository at this point in the history

  4. Remove excess vertical ruler if no errors are recognized

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    eb9c4ec View commit details
    Browse the repository at this point in the history

  5. Fix icon alignment of errors/warnings in tree

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f0a3ab3 View commit details
    Browse the repository at this point in the history

  6. Fix warning text color in dark theme

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    5b59bbc View commit details
    Browse the repository at this point in the history

  7. center icons with text instead of baseline

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    0ef80bc View commit details
    Browse the repository at this point in the history

  8. Clear errorsAndWarnings when elements are removed

    @eps1lon
    eps1lon committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    6192477 View commit details
    Browse the repository at this point in the history

  9. Tweaked inline element style for warning/error icons

    Brian Vaughn committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    6e57b4d View commit details
    Browse the repository at this point in the history

  10. Fixed minor regression in Element styles

    Brian Vaughn committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    2df0740 View commit details
    Browse the repository at this point in the history

  11. Split errors and warnings into separate panels

    Brian Vaughn committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    52f0494 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Implement new message format 

    When flushing messages we use a new type of operation instead that only contains the number of warnings/errors.
The messages itself are only sent as part of the inspectElement event.
Already implemented a mapping from the message to a unique id.
Though I'm not quite sure why we wanted to do that.
Did we want to send the message only once and then ids if it repeats?
    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d64023c View commit details
    Browse the repository at this point in the history

  2. Reflect error/warning updates in tree when cleared

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1bb99d9 View commit details
    Browse the repository at this point in the history

  3. Fix inspectedElement not updating on error/warnings update

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c197030 View commit details
    Browse the repository at this point in the history

  4. fix minor flow issues

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    2a3423f View commit details
    Browse the repository at this point in the history

  5. Fix style regressions during rebase

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9df59c6 View commit details
    Browse the repository at this point in the history

  6. Move Stepper UX to end of toolbar

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    bdf5d0e View commit details
    Browse the repository at this point in the history

  7. Cleanup WIP artifacts

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3a37795 View commit details
    Browse the repository at this point in the history

  8. Add tally of errors/warnings

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    91366be View commit details
    Browse the repository at this point in the history

  9. Remove nullish coalescing 

    Not supported by jest config
    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    cc59c71 View commit details
    Browse the repository at this point in the history

  10. Cleaned up CSS colors and made some other small UI tweaks

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d164fac View commit details
    Browse the repository at this point in the history

  11. Make more room in toolbar 

    Only show search controls when there is search text entered.

Don't show error overlay in the owners view. (We also hide search controls in this view as well, to make more room for breadcrumbs
    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    860d0e7 View commit details
    Browse the repository at this point in the history

  12. Add new debug setting for showing inline warnings and errors 

    Refactored console patching logic to account for this new setting.
    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5cb19ac View commit details
    Browse the repository at this point in the history

  13. Strip component stacks from errors/warnings before passing them to fr… 

    …ontend
    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    674e287 View commit details
    Browse the repository at this point in the history

  14. Fixed a spot I missed with new inline warnings setting

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0e0b8c7 View commit details
    Browse the repository at this point in the history

  15. De-dupe warnings and errors and show badge count for duplciate entries

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5073d81 View commit details
    Browse the repository at this point in the history

  16. Fixed dedupe badge text contrast

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    99de4ff View commit details
    Browse the repository at this point in the history

  17. Oops I left a console log statement in

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    095c118 View commit details
    Browse the repository at this point in the history

  18. Minor UI tweaks

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e8b7dc5 View commit details
    Browse the repository at this point in the history

  19. Clean up component stack remove in messages

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3ab78da View commit details
    Browse the repository at this point in the history

  20. Remove WIP artifacts

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    15122d2 View commit details
    Browse the repository at this point in the history

  21. Fixed bug when calculating total error/warning count

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    26cecfa View commit details
    Browse the repository at this point in the history

  22. Merge branch 'devtools-show-warnings-in-tree' of github.com:eps1lon/r… 

    …eact into devtools-show-warnings-in-tree
    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1f1a161 View commit details
    Browse the repository at this point in the history

  23. Use empty string instead of "fixing" the format string

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    caf8678 View commit details
    Browse the repository at this point in the history

  24. Fix test harness to avoid double logging 

    Component stack generation relies on intentionally triggering common sources of errors when shallow-rendering a component. Our inline error test harness didn't trip these paths for most components, and so it appeared to double log most of its warnings/errors. This commit fixes that.
    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    a4f0059 View commit details
    Browse the repository at this point in the history

  25. Added a few more test cases to the inline error test harness

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5719f31 View commit details
    Browse the repository at this point in the history

  26. Show full message on click

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    92ebd81 View commit details
    Browse the repository at this point in the history

  27. Revert 92ebd81

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    70099e5 View commit details
    Browse the repository at this point in the history

  28. Show full error/warning text as tooltip on hover

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1b6e292 View commit details
    Browse the repository at this point in the history

  29. inline errors and warnings are not implemented in legacy devtools

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    61bf6a3 View commit details
    Browse the repository at this point in the history

  30. Added missing key error test

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    46cea44 View commit details
    Browse the repository at this point in the history

  31. Move batching to backend/console

    @eps1lon
    eps1lon committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    8b5c8d9 View commit details
    Browse the repository at this point in the history

  32. move filter into forEach

    @eps1lon
    eps1lon committed Dec 16, 2020
    1 Configuration menu
    Copy the full SHA
    0146bc3 View commit details
    Browse the repository at this point in the history

  33. Added some basic tests for inline errors/warnings

    Brian Vaughn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    04ffb01 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Add tests for the store

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9380545 View commit details
    Browse the repository at this point in the history

  2. Update snapshot due to previous typo fix

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8ff2c7b View commit details
    Browse the repository at this point in the history

  3. Remove outdated snapshot

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5824f48 View commit details
    Browse the repository at this point in the history

  4. Refactored error/warning message queueing and bundling

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8fc6249 View commit details
    Browse the repository at this point in the history

  5. Fixed Store tests by updating to inline snapshots

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    f0ceff6 View commit details
    Browse the repository at this point in the history

  6. Prevent siliencing of unexpected console calls in inspectedElementCon… 

    …text-test
    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    1c1874c View commit details
    Browse the repository at this point in the history

  7. Actually use generic param

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    ef149c9 View commit details
    Browse the repository at this point in the history

  8. Use inline snapshots

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5c892ac View commit details
    Browse the repository at this point in the history

  9. Add tests for clearing errors and warnings

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8953cdc View commit details
    Browse the repository at this point in the history

  10. Run the minimal amount of timer necessary

    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    268a25b View commit details
    Browse the repository at this point in the history

  11. Revert "Run the minimal amount of timer necessary" 

    This reverts commit 268a25b.
    @eps1lon
    eps1lon committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    6e167a3 View commit details
    Browse the repository at this point in the history

  12. Added tests (and bug fix) for select next/prev error

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    69410ac View commit details
    Browse the repository at this point in the history

  13. Fixed an error (but left a TODO for a better future fix)

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    6feb404 View commit details
    Browse the repository at this point in the history

  14. Added two (failing) tests that we should fix

    Brian Vaughn committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    da0aad2 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. select(Prev|Next)Error -> select(Prev|Next)ErrorOrWarning 

    Maybe we should've called it "Issues" instead but now that we've written it so often we might as well keep it?!
Or just avoid the bikeshedding altogether...
    @eps1lon
    eps1lon committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    35b16ce View commit details
    Browse the repository at this point in the history

  2. Serialize errors and warnings in snapshots

    @eps1lon
    eps1lon committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    af1c54e View commit details
    Browse the repository at this point in the history

  3. Use statefulStore serializer in "inline error/warning" tests

    @eps1lon
    eps1lon committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a0a8e06 View commit details
    Browse the repository at this point in the history

  4. Fix flow issues

    @eps1lon
    eps1lon committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    5b5d2c5 View commit details
    Browse the repository at this point in the history

  5. Refactored treeContext tests to use inline snapshots and Jest serializer

    Brian Vaughn committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    4a87383 View commit details
    Browse the repository at this point in the history

  6. Inline warnings/errors should respect component filters 

    Adjusting filters should also update errors/warnings.

Also optimized the filter update flow by adding a REMOVE_ALL operation.

Lots of new tests added.
    Brian Vaughn committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    781d8b7 View commit details
    Browse the repository at this point in the history

  7. Add error/warning counts to serialized store snapshot 

    This lets us remove ugly expect-map-to-be statements
    Brian Vaughn committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e69c0b4 View commit details
    Browse the repository at this point in the history

  8. Add failing test for uncommitted renders

    @eps1lon
    eps1lon committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    bc788d8 View commit details
    Browse the repository at this point in the history

  9. Don't send errors/warnings for suspended or errored subtrees

    Brian Vaughn committed Dec 18, 2020
    1 Configuration menu
    Copy the full SHA
    22c3f4b View commit details
    Browse the repository at this point in the history

  10. Wait to flush errors/warnings until the next commit; it's safer

    Brian Vaughn committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b9fa573 View commit details
    Browse the repository at this point in the history

  11. Remove separate 'errorsAndWarnings' event in favor of 'mutations' 

    This avoids the case of one being updated without the other.
    Brian Vaughn committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    4c9bf65 View commit details
    Browse the repository at this point in the history

  12. Refactored next/prev index calculation and memoized error/warning count

    Brian Vaughn committed Dec 18, 2020
    1 Configuration menu
    Copy the full SHA
    a27fc21 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Serialize warn/error tally above roots 

    They're not counted by root currently so displaying them next to a root is misleading
    @eps1lon
    eps1lon committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    83991b1 View commit details
    Browse the repository at this point in the history

  2. Test multi-root app when testing next/prev error selection

    @eps1lon
    eps1lon committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    ca5f050 View commit details
    Browse the repository at this point in the history

  3. Updated snapshots

    Brian Vaughn committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    51d3cac View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Added multi-root tests for tree context wrapping

    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    4174fbd View commit details
    Browse the repository at this point in the history

  2. Merged in master

    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    85ed51d View commit details
    Browse the repository at this point in the history

  3. Add docs for TREE_OPERATION_REMOVE_ROOT

    @eps1lon
    eps1lon committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    b79d1d9 View commit details
    Browse the repository at this point in the history

  4. Misc small things: Updated OVERVIEW, TODO, debug log, and minor forma… 

    …tting changes
    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    6f15c87 View commit details
    Browse the repository at this point in the history

  5. Cleanup after unmounted/never-mounted Fibers that have errors/warning… 

    …s logged
    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    fa41522 View commit details
    Browse the repository at this point in the history

  6. Auto-refresh inspected element right after cleaning warings/errors 

    This makes the UI feel more responsive.

Ideally, we'd disable the button and wait until the update came through via something like useTransition, but implementing that would be complicated with the way DevTools is currently implemented so I chose to do it this way instead for now.
    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    aa5f89d View commit details
    Browse the repository at this point in the history

  7. Auto-refresh inspected element right after cleaning warings/errors 

    This is a temporary solution until we are using a more modern Cache in DevTools.
    Brian Vaughn committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    5d10e41 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Standalone CSS style fix for warning/error count font size

    Brian Vaughn committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    05a2825 View commit details
    Browse the repository at this point in the history

  2. Pre-compute and cache the error/warning id-and-index tuples

    Brian Vaughn committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    7e149e8 View commit details
    Browse the repository at this point in the history

  3. Small variable naming cleanup in Store

    Brian Vaughn committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    5a3ae6c View commit details
    Browse the repository at this point in the history