Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /dist/ UMD builds #18473

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Remove /dist/ UMD builds #18473

merged 2 commits into from
Apr 3, 2020

Conversation

sebmarkbage
Copy link
Collaborator

We publish UMDs to npm (and we're considering stopping even that) and nowhere else.

This means we'll stop publishing to @zpao's http://react.zpao.com/builds/master/latest/

We publish UMDs to npm (and we're considering stopping even that).

This means we'll stop publishing to http://react.zpao.com/builds/master/latest/
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 3, 2020
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but there are some other matches in fixtures and old scripts. Admittedly likely broken for other reasons but might be nice to fix to point to node_modules/.../umd.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9633b3:

Sandbox Source
thirsty-lake-9d8zc Configuration

@sizebot
Copy link

sizebot commented Apr 3, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against a9633b3

@sizebot
Copy link

sizebot commented Apr 3, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against a9633b3

@sebmarkbage sebmarkbage merged commit 3c16baf into facebook:master Apr 3, 2020
@elas7 elas7 mentioned this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants