Feature Flag for React.jsx' "spreading a key to jsx" warning #18074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
threepointone
changed the title
Details of bundled changes.Comparing: 4912ba3...96c85c6 react
react-dom
react-reconciler
scheduler
react-art
React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
threepointone
force-pushed
the
jsx-spread-warning-feature-flag
branch
from
f15ee76
to
6c60013
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Details of bundled changes.Comparing: 4912ba3...96c85c6 react
react-dom
react-art
react-reconciler
scheduler
ReactDOM: size: 0.0%, gzip: 🔺+0.1% React: size: 0.0%, gzip: 0.0% Size changes (stable) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
threepointone
commented
Feb 19, 2020
| @@ -365,13 +369,20 @@ export function jsxWithValidation( | |||
| } | |||
| } | |||
|
|
|||
| if (hasOwnProperty.call(props, 'key')) { | |||
There was a problem hiding this comment.
moved this inside the __DEV__ block. It wasn't being DCEed, so that gets us a few bytes back too.
There was a problem hiding this comment.
Wait, wasn’t this whole file supposed to be dev only? Are you saying this function is used in prod?
There was a problem hiding this comment.
Oh hmm you're right. I only glanced at sizebot, probably not relevant.
threepointone
commented
Feb 19, 2020
threepointone
force-pushed
the
jsx-spread-warning-feature-flag
branch
2 times, most recently
from
0643ad6
to
513ed10
Compare
threepointone
commented
Feb 19, 2020
threepointone
force-pushed
the
jsx-spread-warning-feature-flag
branch
from
513ed10
to
78f69d0
Compare
Adds a feature flag for when React.jsx warns you about spreading a key into jsx. It's false for all builds, except as a dynamic flag for fb/www. I also included the component name in the warning.
threepointone
force-pushed
the
jsx-spread-warning-feature-flag
branch
from
43bd414
to
96c85c6
Compare
gaearon
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag for when
React.jsxwarns you about spreading a key into jsx. It's false for all builds, except as a dynamic flag for fb/www.I also included the component name in the warning.