[react-interactions] Remove deprecated Scope APIs + update Focus components #17859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
trueadm
force-pushed
the
remove-scope-apis
branch
from
f0c9bac
to
05a92b9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0c9bac:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb9da2a:
|
threepointone
approved these changes
Jan 17, 2020
Details of bundled changes.Comparing: b6173e6...cb9da2a react-test-renderer
react-native-renderer
react-art
react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: b6173e6...cb9da2a react-native-renderer
react-reconciler
react-dom
react-art
react-test-renderer
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
trueadm
force-pushed
the
remove-scope-apis
branch
from
05a92b9
to
05ea82d
Compare
…onents/docs Remove Update tests
trueadm
force-pushed
the
remove-scope-apis
branch
from
05ea82d
to
cb9da2a
Compare
About a year later, I'd like to ask if there's any plan or progress to bring these back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated Scope APIs that handled traversal. These APIs are no longer used internally, and instead now use React Context and the
scope.getChildContextValues()API exclusively.Unfortunately, I've decided to also remove the
accessibilitydirectory from the React repository for now, which includes the accessibility components. Many of the tests/docs/components were out of date compared to their latest versions, which were migrated to our internal FB repository last year. Keeping the components in sync proved to be very time-consuming because of several differences. Notably, our internal Jest tests for these components made usage of our internal testing infrastructure which is not available in open-source right now, plus there were usages of other bits of Facebook IP that I'd have to remove before syncing back over.A more effecient long-term strategy will be to work with the partner teams involved and come up with a plan that involves moving these components back into open-source, probably under a different repository maybe, or maybe a different project relating to Facebook's accessibility work.