Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Rerender Error Check #17519

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

sebmarkbage
Copy link
Collaborator

This didn't work. Because the rerender count zero ends up being used as a signal that we should process any remaining useState updates even if the first pass has already scheduled an update.

Will revisit in #17484

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 4, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afef372:

Sandbox Source
adoring-flower-54j8s Configuration

@sebmarkbage sebmarkbage merged commit 5064c7f into facebook:master Dec 4, 2019
@sizebot
Copy link

sizebot commented Dec 4, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against afef372

@sizebot
Copy link

sizebot commented Dec 4, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against afef372

trueadm pushed a commit to trueadm/react that referenced this pull request Dec 4, 2019
* Add failing test

* Revert "Move rerender error check to avoid global state"

This reverts commit 3e77742.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants