Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for update on different component in render #17099

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 15, 2019

This warning already exists for class components, but not for functions.

It does not apply to render phase updates to the same component, which have special semantics that we do support.

@sizebot
Copy link

sizebot commented Oct 15, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: a8c6a1b...bd8fbdb

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% 0.0% 668.18 KB 668.56 KB 145.35 KB 145.4 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 103.67 KB 103.67 KB 31.51 KB 31.51 KB UMD_PROD
react-art.development.js +0.1% 0.0% 598.81 KB 599.19 KB 127.95 KB 128 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 68.69 KB 68.69 KB 20.8 KB 20.8 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 611.99 KB 612.37 KB 127.55 KB 127.62 KB FB_WWW_DEV
ReactART-prod.js 0.0% 0.0% 232.34 KB 232.34 KB 39.18 KB 39.18 KB FB_WWW_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 119.46 KB 119.46 KB 37.7 KB 37.69 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 140.06 KB 140.06 KB 36.8 KB 36.8 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 968.76 KB 969.15 KB 215.37 KB 215.44 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.84 KB 19.84 KB 7.37 KB 7.37 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 56.31 KB 56.31 KB 15.59 KB 15.59 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 701 B 699 B UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.58 KB 54.58 KB 15.25 KB 15.25 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.04 KB 1.04 KB 632 B 630 B NODE_PROD
react-dom.development.js 0.0% 0.0% 946.8 KB 947.18 KB 214.52 KB 214.56 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 115.7 KB 115.7 KB 37.25 KB 37.25 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.22 KB 119.22 KB 38.33 KB 38.33 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 940.87 KB 941.25 KB 212.95 KB 213 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 137.1 KB 137.1 KB 36.02 KB 36.02 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.81 KB 115.81 KB 36.69 KB 36.68 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.17 KB 20.17 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOM-profiling.js 0.0% 0.0% 398.87 KB 398.87 KB 72.99 KB 72.99 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.99 KB 135.99 KB 35.8 KB 35.8 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.76 KB 19.76 KB 7.35 KB 7.35 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.72 KB 10.72 KB 3.67 KB 3.66 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 139.29 KB 139.29 KB 35.33 KB 35.32 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.5 KB 48.5 KB 11.08 KB 11.08 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.8 KB 59.8 KB 15.66 KB 15.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.46 KB 10.46 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.1 KB 1.1 KB 666 B 665 B NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% +0.1% 623.53 KB 623.91 KB 130.09 KB 130.16 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 38.56 KB 38.56 KB 9.9 KB 9.9 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.43 KB 11.43 KB 3.54 KB 3.54 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.53 KB 32.53 KB 8.42 KB 8.42 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.57 KB 11.57 KB 3.63 KB 3.63 KB NODE_PROD
react-test-renderer.development.js +0.1% 0.0% 612.88 KB 613.26 KB 130.96 KB 131 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 70.71 KB 70.71 KB 21.64 KB 21.64 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 608.15 KB 608.53 KB 129.77 KB 129.81 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 70.41 KB 70.41 KB 21.32 KB 21.31 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 599.79 KB 600.17 KB 127.12 KB 127.17 KB NODE_DEV
react-reconciler.production.min.js 0.0% -0.0% 71.41 KB 71.41 KB 21.1 KB 21.1 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% -0.0% 19.19 KB 19.19 KB 6.26 KB 6.26 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.2% 2.85 KB 2.85 KB 1.24 KB 1.23 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% 0.0% 597.14 KB 597.52 KB 125.99 KB 126.04 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% -0.0% 71.42 KB 71.42 KB 21.11 KB 21.11 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 0.0% -0.0% 272.58 KB 272.58 KB 46.75 KB 46.74 KB RN_OSS_PROD
ReactFabric-prod.js 0.0% -0.0% 264.34 KB 264.34 KB 45.36 KB 45.36 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% -0.0% 275.17 KB 275.17 KB 47.27 KB 47.27 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% 0.0% 747.38 KB 747.76 KB 158.43 KB 158.5 KB RN_FB_DEV
ReactNativeRenderer-dev.js +0.1% 0.0% 741.72 KB 742.1 KB 157.51 KB 157.58 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% -0.0% 275.17 KB 275.17 KB 47.29 KB 47.28 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.1% 0.0% 741.88 KB 742.26 KB 157.6 KB 157.67 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% -0.0% 272.57 KB 272.57 KB 46.76 KB 46.76 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 282.31 KB 282.31 KB 48.54 KB 48.54 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% 0.0% 747.21 KB 747.59 KB 158.36 KB 158.43 KB RN_OSS_DEV

Generated by 🚫 dangerJS against bd8fbdb

'Cannot update during an existing state transition (such as ' +
'within `render`). Render methods should be a pure function of ' +
'props and state.',
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use warningWithoutStack instead of warning here?

@@ -491,6 +491,50 @@ describe('ReactHooksWithNoopRenderer', () => {
]);
expect(ReactNoop.getChildren()).toEqual([span(22)]);
});

it('warns about render phase update on a different component', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume there's already a test for it not warning if it's the same component?

@acdlite
Copy link
Collaborator Author

acdlite commented Jan 23, 2020

@sebmarkbage @gaearon Do we want to land this warning? If so I'll update it

@gaearon
Copy link
Collaborator

gaearon commented Feb 19, 2020

@ermanzohre Can I ask you to please not “approve” old pull requests? Your actions are creating notification noise for everyone watching the repo. Thanks.

This warning already exists for class components, but not for functions.

It does not apply to render phase updates to the same component, which
have special semantics that we do support.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sizebot
Copy link

sizebot commented Feb 19, 2020

Details of bundled changes.

Comparing: 085d021...1051db9

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.81 KB 123.81 KB 38.73 KB 38.73 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 990.26 KB 990.7 KB 218.29 KB 218.38 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.36 KB 121.36 KB 38.26 KB 38.26 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 11.23 KB 11.23 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.46 KB 20.46 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.71 KB 135.71 KB 36.09 KB 36.09 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11 KB 11 KB 4.11 KB 4.11 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 969.98 KB 970.41 KB 217.9 KB 217.97 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.73 KB 58.73 KB 15.36 KB 15.36 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.96 KB 119.96 KB 38.34 KB 38.34 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 123.59 KB 123.59 KB 39.52 KB 39.52 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 964.06 KB 964.49 KB 216.27 KB 216.34 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.43 KB 58.43 KB 15.28 KB 15.28 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 120.02 KB 120.02 KB 37.58 KB 37.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 698 B 697 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.82 KB 967.25 KB 216.74 KB 216.81 KB UMD_DEV
react-dom-testing.production.min.js 0.0% -0.0% 117.6 KB 117.6 KB 37.89 KB 37.88 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 989.77 KB 990.2 KB 218.16 KB 218.26 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 371.5 KB 371.5 KB 67.65 KB 67.65 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.9 KB 961.33 KB 215.11 KB 215.18 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 371.5 KB 371.5 KB 67.65 KB 67.65 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 136.82 KB 136.82 KB 36.32 KB 36.32 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.79 KB 20.79 KB 7.62 KB 7.62 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.1% +0.1% 625.45 KB 625.88 KB 129.19 KB 129.29 KB FB_WWW_DEV
react-art.development.js +0.1% 0.0% 682.43 KB 682.86 KB 146.87 KB 146.94 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 107.54 KB 107.54 KB 32.53 KB 32.52 KB UMD_PROD
react-art.development.js +0.1% +0.1% 613.1 KB 613.53 KB 129.46 KB 129.53 KB NODE_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 626.21 KB 626.65 KB 132.06 KB 132.13 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 72.16 KB 72.16 KB 21.96 KB 21.96 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 621.48 KB 621.91 KB 130.87 KB 130.94 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.93 KB 71.93 KB 21.63 KB 21.63 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 636.94 KB 637.38 KB 131.69 KB 131.78 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 37.89 KB 37.89 KB 9.84 KB 9.84 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.66 KB 11.66 KB 3.6 KB 3.6 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.43 KB 32.43 KB 8.53 KB 8.53 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.79 KB 11.79 KB 3.71 KB 3.71 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.1% +0.1% 721.47 KB 721.91 KB 152.51 KB 152.6 KB RN_FB_DEV
ReactNativeRenderer-dev.js +0.1% +0.1% 730.78 KB 731.21 KB 154.56 KB 154.66 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% -0.0% 267.71 KB 267.71 KB 46.25 KB 46.25 KB RN_OSS_PROD
ReactNativeRenderer-dev.js +0.1% +0.1% 730.95 KB 731.38 KB 154.65 KB 154.74 KB RN_FB_DEV
ReactFabric-dev.js +0.1% +0.1% 721.29 KB 721.72 KB 152.42 KB 152.52 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.1% +0.1% 615.41 KB 615.84 KB 128.53 KB 128.6 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 20.54 KB 20.54 KB 6.76 KB 6.76 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% -0.0% 73.76 KB 73.76 KB 21.79 KB 21.79 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.86 KB 2.86 KB 1.24 KB 1.24 KB NODE_PROD
react-reconciler.development.js +0.1% +0.1% 619.22 KB 619.65 KB 130.04 KB 130.11 KB NODE_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 1051db9

@sizebot
Copy link

sizebot commented Feb 19, 2020

Details of bundled changes.

Comparing: 085d021...1051db9

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-testing.production.min.js 0.0% -0.0% 117.15 KB 117.15 KB 37.05 KB 37.05 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.72 KB 58.72 KB 15.35 KB 15.35 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.83 KB 120.83 KB 38.13 KB 38.13 KB NODE_PROFILING
react-dom.development.js 0.0% 0.0% 969.96 KB 970.39 KB 217.89 KB 217.96 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 690 B 689 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 116.04 KB 116.04 KB 37.24 KB 37.24 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20 KB 20 KB 7.4 KB 7.4 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 989.76 KB 990.19 KB 218.15 KB 218.25 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 964.04 KB 964.47 KB 216.25 KB 216.32 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 135.68 KB 135.68 KB 36.09 KB 36.09 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 116.08 KB 116.08 KB 36.56 KB 36.56 KB NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.79 KB 967.22 KB 216.73 KB 216.8 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.39 KB 7.39 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.75 KB 119.75 KB 37.66 KB 37.66 KB NODE_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.07 KB 117.07 KB 37.72 KB 37.72 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 991.21 KB 991.64 KB 218.6 KB 218.69 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% -0.0% 140.46 KB 140.46 KB 35.55 KB 35.55 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 397.23 KB 397.23 KB 72.18 KB 72.18 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.87 KB 961.31 KB 215.09 KB 215.16 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.42 KB 58.42 KB 15.28 KB 15.28 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 55.98 KB 55.98 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.25 KB 54.25 KB 15.47 KB 15.46 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.34 KB 20.34 KB 7.54 KB 7.54 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.1% +0.1% 721.28 KB 721.71 KB 152.42 KB 152.51 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.1% +0.1% 730.76 KB 731.2 KB 154.56 KB 154.65 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.1% +0.1% 615.4 KB 615.83 KB 128.53 KB 128.59 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% -0.0% 73.75 KB 73.75 KB 21.78 KB 21.78 KB NODE_PROD
react-reconciler.development.js +0.1% +0.1% 619.21 KB 619.64 KB 130.04 KB 130.11 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.85 KB 2.85 KB 1.24 KB 1.24 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% 0.0% 682.4 KB 682.83 KB 146.87 KB 146.94 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 104.98 KB 104.98 KB 31.84 KB 31.84 KB UMD_PROD
react-art.development.js +0.1% +0.1% 613.08 KB 613.51 KB 129.46 KB 129.53 KB NODE_DEV
ReactART-dev.js +0.1% +0.1% 625.44 KB 625.87 KB 129.18 KB 129.28 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.production.min.js 0.0% -0.0% 71.91 KB 71.91 KB 21.61 KB 21.61 KB NODE_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.42 KB 32.42 KB 8.52 KB 8.52 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.78 KB 11.78 KB 3.7 KB 3.7 KB NODE_PROD
react-test-renderer.development.js +0.1% +0.1% 626.19 KB 626.62 KB 132.04 KB 132.12 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 72.13 KB 72.13 KB 21.94 KB 21.94 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 621.45 KB 621.89 KB 130.86 KB 130.93 KB NODE_DEV
ReactTestRenderer-dev.js +0.1% +0.1% 636.93 KB 637.36 KB 131.68 KB 131.78 KB FB_WWW_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 1051db9

@acdlite acdlite merged commit ea6ed3d into facebook:master Feb 19, 2020
switch (fiber.tag) {
case FunctionComponent:
case ForwardRef:
case SimpleMemoComponent: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should include Block too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants