[react-interactions] Add tab handling to FocusList #16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 10c7dfe...86fb6d8 react-interactions
|
threepointone
approved these changes
Sep 30, 2019
necolas
reviewed
Sep 30, 2019
| @@ -158,6 +158,33 @@ function testWithPointerType(message, testFn) { | |||
| }); | |||
| } | |||
|
|
|||
| function emulateBrowserTab(backwards) { | |||
There was a problem hiding this comment.
Please can you move this into the test file you're using it in, for now
There was a problem hiding this comment.
Sure. Will do in a follow up! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #16922, where we add the same tab keyboard control behavior to
FocusList