[react-ui] FocusGrid -> ReactFocusTable + tweaks and fixes #16806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think "navigate" implies a change of screen and url, rather than focus exiting the component |
|
@necolas Agreed, I'll change the summary of the PR to reflect. |
necolas
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of work for the experimental React Accessibility components. Notably, this PR changes:
FocusGrid->ReactFocusTableto better reflect that it handles keyboard interactions (arrow keys) with layout matching that of a static table.onNavigateOutprop that can be used on FocusTables to control the behavior when a user keyboard interactions out of a table's bounds. The callback provides thedirectionand a helper method to select another table of the same type.