Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's schedule the passive effects even earlier #16714

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

sebmarkbage
Copy link
Collaborator

It turns out I needed to schedule mine in the mutation phase and there are also clean up life-cycles there.

@sizebot
Copy link

sizebot commented Sep 9, 2019

Details of bundled changes.

Comparing: cc2492c...21820cc

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 269.61 KB 269.86 KB 46.23 KB 46.31 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% +0.1% 278.29 KB 278.38 KB 47.84 KB 47.9 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.3% 🔺+0.4% 260.95 KB 261.61 KB 44.84 KB 45.01 KB RN_OSS_PROD
ReactFabric-profiling.js +0.2% +0.3% 269.96 KB 270.47 KB 46.44 KB 46.6 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% 0.0% 743.91 KB 743.98 KB 157.14 KB 157.15 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.3% 🔺+0.4% 260.95 KB 261.61 KB 44.85 KB 45.03 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% 0.0% 737.3 KB 737.38 KB 155.98 KB 155.99 KB RN_OSS_DEV
ReactFabric-profiling.js +0.2% +0.3% 269.96 KB 270.46 KB 46.45 KB 46.61 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% 0.0% 737.46 KB 737.54 KB 156.05 KB 156.07 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 269.6 KB 269.85 KB 46.24 KB 46.32 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% +0.1% 278.28 KB 278.37 KB 47.85 KB 47.91 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% 0.0% 743.74 KB 743.81 KB 157.06 KB 157.07 KB RN_OSS_DEV

Generated by 🚫 dangerJS against 21820cc

It turns out I needed to schedule mine in the mutation phase and there
are also clean up life-cycles there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants