Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Fix ESLint rule crash in an edge case #15044

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 7, 2019

The fix itself is a bit shady but we already rely on this hack in a few places. I'd like to find a way to avoid it in the future but at least this fixes the crash. (This could also be an ESLint bug, I'm not sure.)

@sizebot
Copy link

sizebot commented Mar 7, 2019

Details of bundled changes.

Comparing: 9b7e1d1...366f95d

eslint-plugin-react-hooks

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
eslint-plugin-react-hooks.development.js +0.6% +0.6% 65.39 KB 65.79 KB 15.13 KB 15.22 KB NODE_DEV
eslint-plugin-react-hooks.production.min.js 🔺+0.4% 🔺+0.5% 16.83 KB 16.91 KB 5.81 KB 5.84 KB NODE_PROD
ESLintPluginReactHooks-dev.js +0.6% +0.6% 69.9 KB 70.31 KB 15.52 KB 15.62 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@gaearon gaearon merged commit 6d2666b into facebook:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants