Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn if an unmounted component is pinged #14158

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Nov 8, 2018

We had a test for this, but not outside of concurrent mode. I moved the warning from scheduleWorkToRoot (which is used for both updates and for pings) to scheduleWork (which is only used by updates).

Found by fuzz tester and also reported by @jstejada internally

@sizebot
Copy link

sizebot commented Nov 8, 2018

Details of bundled changes.

Comparing: f9e9913...4614409

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@acdlite acdlite merged commit 7fd1661 into facebook:master Nov 9, 2018
@gaearon gaearon mentioned this pull request Nov 13, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Add failing test for ping on unmounted component

We had a test for this, but not outside of concurrent mode :)

* Don't warn if an unmounted component is pinged
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
* Add failing test for ping on unmounted component

We had a test for this, but not outside of concurrent mode :)

* Don't warn if an unmounted component is pinged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants