[schedule] Nested callbacks and continuations #13595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
schedulecontinuation
branch
from
fd1f95b
to
9da68b3
Compare
|
React: size: 🔺+10.3%, gzip: 🔺+7.3% Details of bundled changes.Comparing: b87aabd...9da68b3 react
schedule
Generated by 🚫 dangerJS |
acdlite
force-pushed
the
schedulecontinuation
branch
from
9da68b3
to
9d78125
Compare
Once the API stabilizes, we will move Schedule this into a separate repo. To promote adoption, especially by projects outside the React ecosystem, we'll remove all React-isms from the source and keep it as simple as possible: - No build step. - No static types. - Everything is in a single file. If we end up needing to support multiple targets, like CommonJS and ESM, we can still avoid a build step by maintaining two copies of the same file, but with different exports. This commit also refactors the implementation to split out the DOM- specific parts (essentially a requestIdleCallback polyfill). Aside from the architectural benefits, this also makes it possible to write host- agnostic tests. If/when we publish a version of Schedule that targets other environments, like React Native, we can run these same tests across all implementations.
A "nested callback" is one that is scheduled during the execution of
a parent callback. It should default to the timeout of the parent.
A "continuation" is a callback that is scheduled when yielding
execution. It's scheduled by returning a callback from the parent. It
should have the same timeout as the parent, and because it's a
continuation, it should be inserted into the queue before callbacks of
equal priority (not after, as callbacks are usually scheduled).
Example of a continuation:
function performWork(deadline) {
while (tasks.length > 0) {
const task = tasks.shift();
doTask(task);
if (
tasks.length > 0 &&
!deadline.didTimeout &&
deadline.timeRemaining() <= 0
) {
// Ran out of time. Yield and
// continue later.
return performWork;
}
}
}
scheduleWork(performWork);
acdlite
force-pushed
the
schedulecontinuation
branch
2 times, most recently
from
3b914d6
to
c0140e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #13582
Nested callbacks and continuations …
A "nested callback" is one that is scheduled during the execution of
a parent callback. It should default to the timeout of the parent.
A "continuation" is a callback that is scheduled when yielding
execution. It's scheduled by returning a callback from the parent. It
should have the same timeout as the parent, and because it's a
continuation, it should be inserted into the queue before callbacks of
equal priority (not after, as callbacks are usually scheduled).
Example of a continuation: