Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate test utils mock component follow up #13194

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Deprecate test utils mock component follow up #13194

merged 2 commits into from
Jul 11, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 11, 2018

Follow up for PR #13193

  • Add de-duplication for deprecation warning
  • Added fb.me URL to warning text

@bvaughn bvaughn requested a review from gaearon July 11, 2018 18:26
@bvaughn bvaughn mentioned this pull request Jul 11, 2018
Merged
gaearon
gaearon approved these changes Jul 11, 2018
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2018

Let's not forget to link fb.me before merging.
Just a personal profile gist is fine — I don't think this deserves a website page.

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 11, 2018

Of course not :) I'm writing the Gist now.

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 11, 2018

https://fb.me/test-utils-mock-component

@bvaughn bvaughn merged commit 7b99cea into facebook:master Jul 11, 2018
@bvaughn bvaughn deleted the deprecate-test-utils-mockComponent-part-2 branch July 11, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhunzaker nhunzaker nhunzaker approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @gaearon @nhunzaker @facebook-github-bot