Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for mounting into a document fragment #11047

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

aweary
Copy link
Contributor

@aweary aweary commented Oct 2, 2017

Follow up to #11037 :)

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 4e1d629

https://deploy-preview-11047--reactjs.netlify.com

@gaearon
Copy link
Collaborator

gaearon commented Oct 2, 2017

Was the test failing before #11037?

@aweary
Copy link
Contributor Author

aweary commented Oct 2, 2017

@gaearon it does, it errors at const validatedTag = type.toLowerCase() because type ends up being undefined.

@gaearon gaearon merged commit 5f93ee6 into facebook:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants