Fix some iframe edge cases

Should fix #13648 by being as protective in `setOffsets` than in `getOffsets`
facebook · Sep 14, 2018 · 9a5eaed · 9a5eaed
1 parent 8bc0bca
commit 9a5eaed
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/react-dom/src/client/ReactDOMSelection.js b/packages/react-dom/src/client/ReactDOMSelection.js
@@ -151,9 +151,12 @@ export function getModernOffsetsFromPoints(
  * @param {object} offsets
  */
 export function setOffsets(node, offsets) {
-  const doc = node.ownerDocument || document;
-  const win = doc ? doc.defaultView : window;
-  const selection = win.getSelection();
+  const {ownerDocument} = node;
+  const win = (ownerDocument && ownerDocument.defaultView) || window;
+  const selection = win.getSelection && win.getSelection();
+  if (!selection) {
+    return;
+  }
   const length = node.textContent.length;
   let start = Math.min(offsets.start, length);
   let end = offsets.end === undefined ? start : Math.min(offsets.end, length);
@@ -179,7 +182,7 @@ export function setOffsets(node, offsets) {
     ) {
       return;
     }
-    const range = doc.createRange();
+    const range = ownerDocument.createRange();
     range.setStart(startMarker.node, startMarker.offset);
     selection.removeAllRanges();