Skip to content

Commit

Permalink
Remove legacy hydration mode (#28440)
Browse files Browse the repository at this point in the history
While Meta is still using legacy mode and we can't remove completely,
Meta is not using legacy hydration so we should be able to remove that.

This is just the first step. Once removed, we can vastly simplify the
DOMConfig for hydration.

This will have to be rebased when tests are upgraded.

DiffTrain build for [670d61b](670d61b)
  • Loading branch information
sebmarkbage committed Mar 26, 2024
1 parent eb7de04 commit 8ee89e3
Show file tree
Hide file tree
Showing 18 changed files with 4,624 additions and 6,859 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dbfbfb3312db019183ef92fd2ef110cc7d807e80
670d61bea23470e980ba13c1c8441e375779b0b8
11 changes: 1 addition & 10 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-classic-36e84f9d";
var ReactVersion = "19.0.0-www-classic-841735f0";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -16852,15 +16852,6 @@ if (__DEV__) {
// This is the first render pass. Attempt to hydrate.
pushPrimaryTreeSuspenseHandler(workInProgress); // We should never be hydrating at this point because it is the first pass,

if ((workInProgress.mode & ConcurrentMode) === NoMode) {
return retrySuspenseComponentWithoutHydrating(
current,
workInProgress,
renderLanes,
null
);
}

if (isSuspenseInstanceFallback()) {
// This boundary is in a permanent fallback state. In this case, we'll never
// get an update and we'll never be able to hydrate the final content. Let's just try the
Expand Down
11 changes: 1 addition & 10 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-modern-2edfe4d7";
var ReactVersion = "19.0.0-www-modern-37e2c118";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -16546,15 +16546,6 @@ if (__DEV__) {
// This is the first render pass. Attempt to hydrate.
pushPrimaryTreeSuspenseHandler(workInProgress); // We should never be hydrating at this point because it is the first pass,

if ((workInProgress.mode & ConcurrentMode) === NoMode) {
return retrySuspenseComponentWithoutHydrating(
current,
workInProgress,
renderLanes,
null
);
}

if (isSuspenseInstanceFallback()) {
// This boundary is in a permanent fallback state. In this case, we'll never
// get an update and we'll never be able to hydrate the final content. Let's just try the
Expand Down
Loading

0 comments on commit 8ee89e3

Please sign in to comment.