Skip to content

Commit

Permalink
Reduce install network flake (#27464)
Browse files Browse the repository at this point in the history
## Summary

Avoids potentially flaky network calls leading to failures such as
https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782.
Also makes install faster since we don't need the binary in CI
seemingly.

Electron itself is used to start the standalone binary.

## How did you test this change?

- [x] CI still passes without the binary downloaded. I'm just trusting
[their
docs](https://www.electronjs.org/docs/latest/tutorial/installation) here
that setting this actually ensures the binary isn't downloaded.

DiffTrain build for commit 16619f1.
  • Loading branch information
eps1lon committed Oct 5, 2023
1 parent 2dd6caa commit 51b6c71
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24772,7 +24772,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-0fba3ecf7-20231004";
var ReactVersion = "18.3.0-canary-16619f106-20231005";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8978,7 +8978,7 @@ var devToolsConfig$jscomp$inline_998 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-0fba3ecf7-20231004",
version: "18.3.0-canary-16619f106-20231005",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1191 = {
Expand Down Expand Up @@ -9009,7 +9009,7 @@ var internals$jscomp$inline_1191 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-0fba3ecf7-20231004"
reconcilerVersion: "18.3.0-canary-16619f106-20231005"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1192 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9404,7 +9404,7 @@ var devToolsConfig$jscomp$inline_1040 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-0fba3ecf7-20231004",
version: "18.3.0-canary-16619f106-20231005",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1232 = {
Expand Down Expand Up @@ -9435,7 +9435,7 @@ var internals$jscomp$inline_1232 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-0fba3ecf7-20231004"
reconcilerVersion: "18.3.0-canary-16619f106-20231005"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1233 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-0fba3ecf7-20231004";
var ReactVersion = "18.3.0-canary-16619f106-20231005";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -616,4 +616,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-0fba3ecf7-20231004";
exports.version = "18.3.0-canary-16619f106-20231005";
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-0fba3ecf7-20231004";
exports.version = "18.3.0-canary-16619f106-20231005";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0fba3ecf73900a1b54ed6d3b0617462ac92d2fef
16619f106ab5ba8e6aca19d55be46cce22e4a7ff

0 comments on commit 51b6c71

Please sign in to comment.