Skip to content

Commit

Permalink
Combine ReactJSXElementValidator with main module (#28317)
Browse files Browse the repository at this point in the history
There are too many layers to the JSX runtime implementation. I think
basically everything should be implemented in a single file, so that's
what I'm going to do.

As a first step, this deletes ReactJSXElementValidator and moves all the
code into ReactJSXElement. I can already see how this will help us
remove more indirections in the future.

Next I'm going to do start moving the `createElement` runtime into this
module as well, since there's a lot of duplicated code.

DiffTrain build for [ec160f3](ec160f3)
  • Loading branch information
acdlite committed Feb 20, 2024
1 parent 76bf9a9 commit 3b13b94
Show file tree
Hide file tree
Showing 13 changed files with 1,700 additions and 1,779 deletions.
825 changes: 398 additions & 427 deletions compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Large diffs are not rendered by default.

825 changes: 398 additions & 427 deletions compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c820097716c3d9765bf85bf58202a4975d99e450
ec160f32c28ccab798c73ecccbb36ce121e1640e
Loading

0 comments on commit 3b13b94

Please sign in to comment.