jsx(): Treat __self and __source as normal props (#28257)

These used to be reserved props because the classic React.createElement runtime passed this data as props, whereas the jsxDEV() runtime passes them as separate arguments. This brings us incrementally closer to being able to pass the props object directly through to React instead of cloning a subset into a new object. The React.createElement runtime is unaffected. DiffTrain build for [91caa96](91caa96)
facebook · Feb 7, 2024 · 126187e · 126187e
1 parent 7a01513
commit 126187e
Show file tree

Hide file tree

Showing 13 changed files with 65 additions and 55 deletions.
diff --git a/compiled/facebook-www/JSXDEVRuntime-dev.classic.js b/compiled/facebook-www/JSXDEVRuntime-dev.classic.js
@@ -1129,10 +1129,8 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
-            propName !== "__self" &&
-            propName !== "__source"
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref"
           ) {
             props[propName] = config[propName];
           }

diff --git a/compiled/facebook-www/JSXDEVRuntime-dev.modern.js b/compiled/facebook-www/JSXDEVRuntime-dev.modern.js
@@ -1129,10 +1129,8 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
-            propName !== "__self" &&
-            propName !== "__source"
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref"
           ) {
             props[propName] = config[propName];
           }

diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-f07ac1e2680a26c5b3bf9c651d62c792de71d46d
+91caa96e4261704d42333f5e02ba32d870379fc4
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -24,7 +24,7 @@ if (__DEV__) {
     ) {
       __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
     }
-    var ReactVersion = "18.3.0-www-classic-715010bd";
+    var ReactVersion = "18.3.0-www-classic-87aadbfe";
 
     // ATTENTION
     // When adding new symbols to this file,
@@ -834,8 +834,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -967,8 +972,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -1909,10 +1919,8 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
-            propName !== "__self" &&
-            propName !== "__source"
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref"
           ) {
             props[propName] = config[propName];
           }

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -24,7 +24,7 @@ if (__DEV__) {
     ) {
       __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
     }
-    var ReactVersion = "18.3.0-www-modern-20a278f7";
+    var ReactVersion = "18.3.0-www-modern-fe0a8b28";
 
     // ATTENTION
     // When adding new symbols to this file,
@@ -834,8 +834,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -967,8 +972,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -1909,10 +1919,8 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
-            propName !== "__self" &&
-            propName !== "__source"
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref"
           ) {
             props[propName] = config[propName];
           }

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -160,8 +160,6 @@ function jsx$1(type, config, maybeKey) {
     hasOwnProperty.call(config, propName) &&
       "key" !== propName &&
       "ref" !== propName &&
-      "__self" !== propName &&
-      "__source" !== propName &&
       (props[propName] = config[propName]);
   if (type && type.defaultProps)
     for (propName in ((config = type.defaultProps), config))
@@ -577,4 +575,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-classic-a3f180e9";
+exports.version = "18.3.0-www-classic-88f429a3";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -124,8 +124,6 @@ function jsx$1(type, config, maybeKey) {
     hasOwnProperty.call(config, propName) &&
       "key" !== propName &&
       "ref" !== propName &&
-      "__self" !== propName &&
-      "__source" !== propName &&
       (props[propName] = config[propName]);
   if (type && type.defaultProps)
     for (propName in ((config = type.defaultProps), config))
@@ -569,4 +567,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-modern-97ff7924";
+exports.version = "18.3.0-www-modern-8e8077b5";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -164,8 +164,6 @@ function jsx$1(type, config, maybeKey) {
     hasOwnProperty.call(config, propName) &&
       "key" !== propName &&
       "ref" !== propName &&
-      "__self" !== propName &&
-      "__source" !== propName &&
       (props[propName] = config[propName]);
   if (type && type.defaultProps)
     for (propName in ((config = type.defaultProps), config))
@@ -581,7 +579,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-classic-a4e84017";
+exports.version = "18.3.0-www-classic-5f5e8f54";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -128,8 +128,6 @@ function jsx$1(type, config, maybeKey) {
     hasOwnProperty.call(config, propName) &&
       "key" !== propName &&
       "ref" !== propName &&
-      "__self" !== propName &&
-      "__source" !== propName &&
       (props[propName] = config[propName]);
   if (type && type.defaultProps)
     for (propName in ((config = type.defaultProps), config))
@@ -573,7 +571,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-modern-4076c0c0";
+exports.version = "18.3.0-www-modern-cc698d7e";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
@@ -36374,7 +36374,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-classic-a3f180e9";
+    var ReactVersion = "18.3.0-www-classic-88f429a3";
 
     function createPortal$1(
       children,

diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js
@@ -17490,7 +17490,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1828 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-a4e84017",
+  version: "18.3.0-www-classic-5f5e8f54",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2197 = {
@@ -17520,7 +17520,7 @@ var internals$jscomp$inline_2197 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-www-classic-a4e84017"
+  reconcilerVersion: "18.3.0-www-classic-5f5e8f54"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2198 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -18021,4 +18021,4 @@ exports.useFormStatus = function () {
     return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
   throw Error(formatProdErrorMessage(248));
 };
-exports.version = "18.3.0-www-classic-a4e84017";
+exports.version = "18.3.0-www-classic-5f5e8f54";
diff --git a/compiled/facebook-www/ReactServer-dev.modern.js b/compiled/facebook-www/ReactServer-dev.modern.js
@@ -626,8 +626,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -759,8 +764,13 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref" && // ...and maybe these, too, though we currently rely on them for
+            // warnings and debug information in dev. Need to decide if we're OK
+            // with dropping them. In the jsx() runtime it's not an issue because
+            // the data gets passed as separate arguments instead of props, but
+            // it would be nice to stop relying on them entirely so we can drop
+            // them from the internal Fiber field.
             propName !== "__self" &&
             propName !== "__source"
           ) {
@@ -1622,10 +1632,8 @@ if (__DEV__) {
         for (propName in config) {
           if (
             hasOwnProperty.call(config, propName) && // Skip over reserved prop names
-            propName !== "key" && // TODO: These will no longer be reserved in the next major
-            propName !== "ref" &&
-            propName !== "__self" &&
-            propName !== "__source"
+            propName !== "key" && // TODO: `ref` will no longer be reserved in the next major
+            propName !== "ref"
           ) {
             props[propName] = config[propName];
           }
@@ -2871,7 +2879,7 @@ if (__DEV__) {
             console["error"](error);
           };
 
-    var ReactVersion = "18.3.0-www-modern-e6ecad30";
+    var ReactVersion = "18.3.0-www-modern-2e3e0251";
 
     // Patch fetch
     var Children = {

diff --git a/compiled/facebook-www/ReactServer-prod.modern.js b/compiled/facebook-www/ReactServer-prod.modern.js
@@ -87,8 +87,6 @@ function jsx$1(type, config, maybeKey) {
     hasOwnProperty.call(config, propName) &&
       "key" !== propName &&
       "ref" !== propName &&
-      "__self" !== propName &&
-      "__source" !== propName &&
       (props[propName] = config[propName]);
   if (type && type.defaultProps)
     for (propName in ((config = type.defaultProps), config))
@@ -475,4 +473,4 @@ exports.useId = function () {
 exports.useMemo = function (create, deps) {
   return ReactCurrentDispatcher.current.useMemo(create, deps);
 };
-exports.version = "18.3.0-www-modern-48d2dc77";
+exports.version = "18.3.0-www-modern-a97dcea7";