Skip to content

Commit

Permalink
Remove disableNativeComponentFrames (#26490)
Browse files Browse the repository at this point in the history
## Overview

I'm landing this flag internally so we can delete this

DiffTrain build for [41b4714](41b4714)
  • Loading branch information
rickhanlonii committed Mar 28, 2023
1 parent 2a33a65 commit 0dd3c25
Show file tree
Hide file tree
Showing 23 changed files with 58 additions and 100 deletions.
4 changes: 1 addition & 3 deletions compiled/facebook-www/JSXDEVRuntime-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ function printWarning(level, format, args) {
var dynamicFeatureFlags = require("ReactFeatureFlags");

var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
// On WWW, false is used for a new modern build.

Expand Down Expand Up @@ -399,7 +397,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
4 changes: 1 addition & 3 deletions compiled/facebook-www/JSXDEVRuntime-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ function printWarning(level, format, args) {
var dynamicFeatureFlags = require("ReactFeatureFlags");

var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
// On WWW, true is used for a new modern build.

Expand Down Expand Up @@ -399,7 +397,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
afea1d0c536e0336735b0ea5c74f635527b65785
41b4714f195868193ddfb2a89d2373b1c61387f4
6 changes: 2 additions & 4 deletions compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-d1164e5e";
var ReactVersion = "18.3.0-www-classic-d31cfc1b";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -477,8 +477,6 @@ function checkKeyStringCoercion(value) {
var dynamicFeatureFlags = require("ReactFeatureFlags");

var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
// On WWW, false is used for a new modern build.

Expand Down Expand Up @@ -2226,7 +2224,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
6 changes: 2 additions & 4 deletions compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-38a72ab9";
var ReactVersion = "18.3.0-www-modern-e85ff880";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -477,8 +477,6 @@ function checkKeyStringCoercion(value) {
var dynamicFeatureFlags = require("ReactFeatureFlags");

var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
// On WWW, true is used for a new modern build.

Expand Down Expand Up @@ -2226,7 +2224,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
6 changes: 2 additions & 4 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-3e47da47";
var ReactVersion = "18.3.0-www-classic-cb1f2a68";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -174,8 +174,6 @@ var revertRemovalOfSiblingPrerendering =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -2970,7 +2968,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
6 changes: 2 additions & 4 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-7d72b1b2";
var ReactVersion = "18.3.0-www-modern-88f49f74";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -174,8 +174,6 @@ var revertRemovalOfSiblingPrerendering =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -2967,7 +2965,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down
8 changes: 3 additions & 5 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ var ReactSharedInternals =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -823,7 +821,7 @@ function describeBuiltInComponentFrame(name) {
}
var reentry = !1;
function describeNativeComponentFrame(fn, construct) {
if (disableNativeComponentFrames || !fn || reentry) return "";
if (!fn || reentry) return "";
reentry = !0;
var previousPrepareStackTrace = Error.prepareStackTrace;
Error.prepareStackTrace = void 0;
Expand Down Expand Up @@ -10038,7 +10036,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-9b739764",
version: "18.3.0-www-classic-2da93189",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1324 = {
Expand Down Expand Up @@ -10069,7 +10067,7 @@ var internals$jscomp$inline_1324 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-9b739764"
reconcilerVersion: "18.3.0-www-classic-2da93189"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1325 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
8 changes: 3 additions & 5 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ var ReactSharedInternals =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -707,7 +705,7 @@ function describeBuiltInComponentFrame(name) {
}
var reentry = !1;
function describeNativeComponentFrame(fn, construct) {
if (disableNativeComponentFrames || !fn || reentry) return "";
if (!fn || reentry) return "";
reentry = !0;
var previousPrepareStackTrace = Error.prepareStackTrace;
Error.prepareStackTrace = void 0;
Expand Down Expand Up @@ -9703,7 +9701,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-d49a25e1",
version: "18.3.0-www-modern-0186ab1a",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1304 = {
Expand Down Expand Up @@ -9734,7 +9732,7 @@ var internals$jscomp$inline_1304 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-d49a25e1"
reconcilerVersion: "18.3.0-www-modern-0186ab1a"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1305 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
6 changes: 2 additions & 4 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ var disableInputAttributeSyncing =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -3994,7 +3992,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down Expand Up @@ -39660,7 +39658,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-aeffe63f";
var ReactVersion = "18.3.0-www-classic-b5a26916";

function createPortal$1(
children,
Expand Down
6 changes: 2 additions & 4 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,6 @@ var disableInputAttributeSyncing =
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -3559,7 +3557,7 @@ var componentFrameCache;

function describeNativeComponentFrame(fn, construct) {
// If something asked for a stack inside a fake render, it should get ignored.
if (disableNativeComponentFrames || !fn || reentry) {
if (!fn || reentry) {
return "";
}

Expand Down Expand Up @@ -33709,7 +33707,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-d49a25e1";
var ReactVersion = "18.3.0-www-modern-0186ab1a";

function createPortal$1(
children,
Expand Down
10 changes: 4 additions & 6 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ var Scheduler = require("scheduler"),
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -1069,7 +1067,7 @@ function describeBuiltInComponentFrame(name) {
}
var reentry = !1;
function describeNativeComponentFrame(fn, construct) {
if (disableNativeComponentFrames || !fn || reentry) return "";
if (!fn || reentry) return "";
reentry = !0;
var previousPrepareStackTrace = Error.prepareStackTrace;
Error.prepareStackTrace = void 0;
Expand Down Expand Up @@ -16149,7 +16147,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1771 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-e5f7b5c5",
version: "18.3.0-www-classic-88e5b395",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2145 = {
Expand Down Expand Up @@ -16179,7 +16177,7 @@ var internals$jscomp$inline_2145 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-e5f7b5c5"
reconcilerVersion: "18.3.0-www-classic-88e5b395"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2146 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16419,4 +16417,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-classic-e5f7b5c5";
exports.version = "18.3.0-www-classic-88e5b395";
10 changes: 4 additions & 6 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableLazyContextPropagation =
Expand Down Expand Up @@ -912,7 +910,7 @@ function describeBuiltInComponentFrame(name) {
}
var reentry = !1;
function describeNativeComponentFrame(fn, construct) {
if (disableNativeComponentFrames || !fn || reentry) return "";
if (!fn || reentry) return "";
reentry = !0;
var previousPrepareStackTrace = Error.prepareStackTrace;
Error.prepareStackTrace = void 0;
Expand Down Expand Up @@ -15672,7 +15670,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1740 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-fdb5487c",
version: "18.3.0-www-modern-6fb7a2a8",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2132 = {
Expand Down Expand Up @@ -15703,7 +15701,7 @@ var internals$jscomp$inline_2132 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-fdb5487c"
reconcilerVersion: "18.3.0-www-modern-6fb7a2a8"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2133 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15872,4 +15870,4 @@ exports.unstable_createEventHandle = function (type, options) {
return eventHandle;
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-modern-fdb5487c";
exports.version = "18.3.0-www-modern-6fb7a2a8";
Loading

0 comments on commit 0dd3c25

Please sign in to comment.