Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add missing onError event to Image #9416

Conversation

SergeyKorochansky
Copy link
Contributor

This PR adds onError prop to Image on Android. Closes #7440

Motivation:
We have image feed and show refresh button when image loading had failed.

Usage of onError event is necessary to track loading failures

@ghost
Copy link

ghost commented Aug 15, 2016

By analyzing the blame information on this pull request, we identified @andreicoman11 and @Bhullnatik to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 15, 2016
@SergeyKorochansky SergeyKorochansky changed the title [Android] Add missing image onError event [Android] Add missing onError event to Image Aug 15, 2016
@ghost
Copy link

ghost commented Aug 15, 2016

@webzepter updated the pull request.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2016
@brentvatne
Copy link
Collaborator

Hi there! Thanks for the PR. This was actually intentionally left out because Fresco doesn't fully support it yet, see: #3791 (comment)

@mkonicek
Copy link
Contributor

mkonicek commented Sep 8, 2016

@brentvatne Looks like we emit an ON_ERROR event in native:

new ImageLoadEvent(getId(), ImageLoadEvent.ON_ERROR));

This PR would make it possible to handle it in JS, correct?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2016
@SergeyKorochansky
Copy link
Contributor Author

@mkonicek yes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016
@ghost
Copy link

ghost commented Sep 15, 2016

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @rigdern as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2016
@brentvatne
Copy link
Collaborator

@mkonicek - the problem is that the behaviour is inconsistent with iOS-- once Fresco has similar error semantics this is easy. I don't follow that project closely and I'm not sure what the current state is. if we merge this we have to keep in mind, and document, that the callbacks fire in different situations on each platform.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2016
@lacker
Copy link
Contributor

lacker commented Oct 25, 2016

Hey, so chatting with @brentvatne and based on the discussion in #3791 (comment) and this thread it seems like this current behavior is working as intended, at least as long as Fresco's behavior makes it impossible for iOS and Android to behave consistently. I'm going to close this pull request, but if it is indeed possible to have this with consistent behavior across iOS and Android, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants