-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use commander to parse command-line options #650
Conversation
Makes it a bit more declarative/easier to add new commands and options to the command line.
react-native-cli is installed globally and therefore extremely hard to change. The goal for it is to do as few work as possible, and to forward all the commands to node_modules/react-native/cli.js which can be updated independently. If you want to add a build command, you should add it in cli.js. Hopefully if we've done our job correctly, we'll never update react-native-cli ever again. |
Ah! Sweet, I'll probably leave this for cli.js then. Thanks, will close/reopen against it. |
Updated in #651. |
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
* Press-event, href and target * Fix typo * Add react-native-web accessibility roles * also add web properties to touchables * use window scrolling * Update src/components/ScrollView.re Co-authored-by: Max Thirouin <git@moox.io>
Just making it a bit more declarative/easier to add new commands and options to the command line.
Adding this as a foundation because I want to add more command line tooling like
react-native build
.While in here, is there a reason I'm missing for the split between
react-native-cli
andcli.js
? Can we merge these?