Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from Fri 3 Apr #644

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Updates from Fri 3 Apr #644

merged 1 commit into from
Apr 3, 2015

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Apr 3, 2015

  • Update deps order - core modules first | Amjad Masad
  • [ReactNative] Workaround double cmd+r bug | Christopher Chedeau
  • [react-native] Nicer error for undefined or string tag names | Ben Alpert
  • [ReactNative] Fix script load from local files | Tadeu Zagallo
  • [react_native] JS files from D1961099: Format stack trace on native side | Alex Kotliarskyi
  • [ReactNative] Cleanup TabBar and its example | Christopher Chedeau
  • [ReactNative] Allow recover from debugger error | Tadeu Zagallo
  • [react-native] Update react to 0.13.1, jstransform alongside | Ben Alpert
  • Fixed tap-to-zoom in Groups photo viewer | Sumeet Vaidya
  • Fix hitTest for auto | Tadeu Zagallo
  • [ReactNative] Unfork RKRootView | Tadeu Zagallo
  • [react-packager] Ignore dotfiles in file watching | Amjad Masad

@vjeux
Updates from Fri 3 Apr
c32d9bc 
- Update deps order - core modules first | Amjad Masad
- [ReactNative] Workaround double cmd+r bug | Christopher Chedeau
- [react-native] Nicer error for undefined or string tag names | Ben Alpert
- [ReactNative] Fix script load from local files | Tadeu Zagallo
- [react_native] JS files from D1961099: Format stack trace on native side | Alex Kotliarskyi
- [ReactNative] Cleanup TabBar and its example | Christopher Chedeau
- [ReactNative] Allow recover from debugger error | Tadeu Zagallo
- [react-native] Update react to 0.13.1, jstransform alongside | Ben Alpert
- Fixed tap-to-zoom in Groups photo viewer | Sumeet Vaidya
- Fix hitTest for auto | Tadeu Zagallo
- [ReactNative] Unfork RKRootView | Tadeu Zagallo
- [react-packager] Ignore dotfiles in file watching | Amjad Masad
vjeux
vjeux reviewed Apr 3, 2015
View reviewed changes
Libraries/Components/TabBarIOS/TabBarItemIOS.ios.js
* A custom icon when the tab is selected. It is ignored when a system
* icon is defined. If left empty, the icon will be tinted in blue.
*/
selectedIcon: Image.propTypes.source,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

vjeux added a commit that referenced this pull request Apr 3, 2015
@vjeux
Merge pull request #644 from vjeux/update3
c760ca9 
Updates from Fri 3 Apr
@vjeux vjeux merged commit c760ca9 into facebook:master Apr 3, 2015
facebook-github-bot pushed a commit that referenced this pull request Nov 27, 2017
@woehrl01 @facebook-github-bot
Measure nodes which have margin: auto and align-item: stretch
5f99b1a 
Summary:
If you have a measurable node and set ```marign-left: auto``` + ```align-item:stretch``` on it, it won't get measured and they get a width/height of ```-(nan)```. This change fixes that behaviour. Fixes #644.
Closes facebook/yoga#645

Differential Revision: D6413512

Pulled By: emilsjolander

fbshipit-source-id: 755febeb33bb0d4520ca6b3c28d56ac333e4a14d
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
@woehrl01 @bowerman0
Measure nodes which have margin: auto and align-item: stretch
b86a09f 
Summary:
If you have a measurable node and set ```marign-left: auto``` + ```align-item:stretch``` on it, it won't get measured and they get a width/height of ```-(nan)```. This change fixes that behaviour. Fixes facebook#644.
Closes facebook/yoga#645

Differential Revision: D6413512

Pulled By: emilsjolander

fbshipit-source-id: 755febeb33bb0d4520ca6b3c28d56ac333e4a14d
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
@woehrl01 @bowerman0
Measure nodes which have margin: auto and align-item: stretch
c5e09e4 
Summary:
If you have a measurable node and set ```marign-left: auto``` + ```align-item:stretch``` on it, it won't get measured and they get a width/height of ```-(nan)```. This change fixes that behaviour. Fixes facebook#644.
Closes facebook/yoga#645

Differential Revision: D6413512

Pulled By: emilsjolander

fbshipit-source-id: 755febeb33bb0d4520ca6b3c28d56ac333e4a14d
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
@danleveille @hramos
Clarifying exactly what properties absoluteFill includes (#644)
f1043fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjeux @ide