Fix XMLHttpRequest.abort() not functional due to incorrect lazy loading in RCTNetworking ObjC module #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in RCTNetworking ObjC module
|
By analyzing the blame information on this pull request, we identified @nicklockwood, @sahrens and @vjeux to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Whoops! Good catch. @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1651218775128767/int_phab to review. |
ghost
closed this
in
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
…ng in RCTNetworking ObjC module Summary: Introduced in a major lazy loading refactoring: 060664f. This is especially an issue when aborting a long-lived HTTP connection used as a notification channel, as it will use 1 of the maximum 4 connections per host (default limit defined by iOS' NSURLSession). Closes facebook#5782 Reviewed By: svcscm Differential Revision: D2907600 Pulled By: nicklockwood fb-gh-sync-id: 8406a045904a7ddb61fe1539a0474ec27b5e9e37
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in a major lazy loading refactoring: 060664f.
This is especially an issue when aborting a long-lived HTTP connection used as a notification channel, as it will use 1 of the maximum 4 connections per host (default limit defined by iOS' NSURLSession).