Migrate MainReactPackage to Kotlin #47070
Open
+334
−343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For the sake of Stable API, I'd like to get this class converted to Kotlin
The class is becoming
final
so could be breaking for some users if they subclassMainReactPackage
which I believe this should not be a valid usage of this API.Changelog:
[Android] [Changed] - Migrate MainReactPackage to Kotlin (and make it final)
Differential Revision: D64479418