-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BridgelessDevSupportManager inside .devsupport #46914
Conversation
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cc @alanjhughes |
…ook#46914) Summary: This is a WIP Changelog: [Android] [Changed] - Allow customization of BridgelessDevSupportManager for Expo Go Reviewed By: rshest Differential Revision: D64105790
6d83959
to
f236a98
Compare
This pull request was exported from Phabricator. Differential Revision: D64105790 |
f236a98
to
e543237
Compare
…ook#46914) Summary: This is a WIP Changelog: [Android] [Changed] - Allow customization of BridgelessDevSupportManager for Expo Go Reviewed By: rshest Differential Revision: D64105790
This pull request was exported from Phabricator. Differential Revision: D64105790 |
This pull request was exported from Phabricator. Differential Revision: D64105790 |
e543237
to
cdb61bb
Compare
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cdb61bb
to
61ed65a
Compare
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
61ed65a
to
7a18e05
Compare
This pull request was exported from Phabricator. Differential Revision: D64105790 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D64105790 |
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
7a18e05
to
fca38a4
Compare
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
fca38a4
to
71b07df
Compare
This pull request was exported from Phabricator. Differential Revision: D64105790 |
This pull request has been merged in c867aba. |
This pull request was successfully merged by @cortinico in c867aba When will my fix make it into a release? | How to file a pick request? |
The
BridgelessDevSupportManager
should have lived inside the.devsupport
package alongside all the otherdevsupport related tooling.
It was instead created inside
.runtime
causing a tight coupling withReactHostImpl
.This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular
dependency between ReactHostImpl and BridgelessDevSupportManager
In this diff I'm:
ReactHostDevHelper
ReactHost
rather thanReactHostImpl
.devsupport
package.This is breaking for users that are manually composing a
BridgelessDevSupportManager
orthat are extending the
ReactInstanceDevHelper
.ReactInstanceDevHelper
has 3 new method which will have to be implemented.BridgelessDevSupportManager
is now living in a different package.Changelog:
[Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper
Reviewed By: rshest
Differential Revision: D64105790