Add sendWrappedEventToPackager to InspectorPackagerConnection #46902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Kudo
force-pushed
the
@kudo/sendWrappedEventToPackager
branch
from
3e61a94
to
64496f2
Compare
facebook-github-bot
added
the
Shared with Meta
3 tasks
3 tasks
byCedric
added a commit
to expo/expo
that referenced
this pull request
Oct 14, 2024
# Why These changes came after initial testing with Fusebox & RNDT on RN 0.76. This does NOT change the default debugger to be RNDT yet, pending facebook/react-native#46902. # How - Tweaked the "open js inspector" code to support Fusebox/RNDT better # Test Plan - `bun create expo@<canary> ./test-rndt` - `cd ./test-rndt` - `EXPO_USE_UNSTABLE_DEBUGGER=true bun expo start` - Press `j` to open RNDT # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Kudo
force-pushed
the
@kudo/sendWrappedEventToPackager
branch
from
e6dcd56
to
88a9f8b
Compare
|
@huntie rebase the pr upon 0.76-stable is smooth without conflicts, so i just set the pr's base to 0.76-stable without re-create a new pr. please help to take a look again. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For Expo network inspector, we need a way to send CDP events from native to metro-inspector-proxy. Since the new c++ implemented InspectorPackagerConnection, it's difficult to have a way to send the CDP events. This PR tries to expose a new
sendWrappedEventToPackagerAPI. I think when react-native core adding the network inspector functionality, the new API should also be necessary.Also expose
IInspectorPackagerConnectionas a public interface so that the callsites could integrate it. Not 100% sure howReactAndroid.apibeing generated using OSS scripts, I just manually changed it.Changelog:
[GENERAL] [ADDED] - Add
sendWrappedEventToPackagertoInspectorPackagerConnectionTest Plan: