Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React-RCTAppDelegate.podspec syntax error for USE_HERMES=1 #46075

Conversation

rocketraman
Copy link
Contributor

Summary:

The USE_HERMES flag is set not escaped correctly by React-RCTAppDelegate.podspec, and it does not apply.

The flag needs to be defined as USE_HERMES\=1, but is currently set as USE_HERMES.

Hopefully this will fix #38193.

See #38193 (comment).

Changelog:

Pick one each for the category and type tags:

[IOS] [FIXED] - Fix imports from RCTAppSetupUtils when Hermes is active

Test Plan:

I made the change in my local project and it fixed issues I was having with building my React Native project. See #38193 (comment).

@facebook-github-bot
Copy link
Contributor

Hi @rocketraman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@rocketraman rocketraman force-pushed the rocketraman/38193-use-hermes-flag-syntax branch from 30ee6b3 to 9986deb Compare August 17, 2024 01:00
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 17, 2024
@realsoelynn
Copy link
Contributor

@rocketraman Also please sign the CLA before we can proceed further.

@rocketraman
Copy link
Contributor Author

@rocketraman Also please sign the CLA before we can proceed further.

This is done.

@rocketraman rocketraman force-pushed the rocketraman/38193-use-hermes-flag-syntax branch from 0467d44 to 8f28fd9 Compare August 17, 2024 01:47
The `USE_HERMES` flag is set not escaped correctly by `React-RCTAppDelegate.podspec`, and it does not apply.

The flag needs to be defined as `USE_HERMES\=1`, but is currently set as `USE_HERMES`.

Hopefully this will fix facebook#38193.
@rocketraman rocketraman force-pushed the rocketraman/38193-use-hermes-flag-syntax branch from 8f28fd9 to 44d3db8 Compare August 17, 2024 01:48
@facebook-github-bot
Copy link
Contributor

@realsoelynn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 20, 2024
@facebook-github-bot
Copy link
Contributor

@realsoelynn merged this pull request in 143437a.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @rocketraman in 143437a

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.72.1 -> 'React/RCTAppSetupUtils.h' file not found
4 participants