Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yoga][0.73] Fix archive for MacOS Catalyst #43896

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[Yoga][0.73] Fix archive for MacOS Catalyst #43896

merged 1 commit into from
Apr 12, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Apr 5, 2024 •
edited
Loading

Summary:

Following up #41938, this PR targeting 0.73 will fix an archiving issue for the Yoga pod

Changelog:

[iOS][Fixed] - Fix Yoga archiving with static frameworks on MacOS Catalyst

Test Plan:

Tested locally and by the community

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2024
@cipolleschi cipolleschi changed the title cipolleschi/fix yoga archive 0.73 [Yoga] Fix archive for MacOS Catalyst Apr 5, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable April 5, 2024 09:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against a8a2f1a

@cipolleschi cipolleschi marked this pull request as ready for review April 5, 2024 09:36
@cipolleschi cipolleschi self-assigned this Apr 5, 2024
@cipolleschi cipolleschi changed the title [Yoga] Fix archive for MacOS Catalyst [Yoga][0.73] Fix archive for MacOS Catalyst Apr 5, 2024
@analysis-bot
Copy link

analysis-bot commented Apr 5, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,500,605 -10,884,648
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,754,931 -13,005,336
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b7812a8
Branch: main

@alfonsocj alfonsocj merged commit 2f98436 into 0.73-stable Apr 12, 2024
65 of 69 checks passed
@NOUIY NOUIY mentioned this pull request May 10, 2024
Open
@cortinico cortinico deleted the cipolleschi/fix_yoga_archive_0.73 branch June 10, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cipolleschi cipolleschi

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cipolleschi @analysis-bot @alfonsocj @facebook-github-bot