-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yoga.podspec: fixes archiving for Mac Catalyst #42847
Update Yoga.podspec: fixes archiving for Mac Catalyst #42847
Conversation
7c68926
to
1c5877a
Compare
Hi @kesha-antonov, thanks for opening the issue. Could you either:
|
Hi, yeah, I tried what you propose but it doesn't work unfortunately Also I don't think that problem in Public Headers since XCode shows error that it can't import files that are located as Private Headers We make headers as public for root directory:
On other levels it is private headers:
So for what you propose to work we need to write What do you think? |
@cipolleschi I've made the repro here: https://github.com/kesha-antonov/react-native-mac_catalyst_archiving_issue_05_02_2024 |
Hi @kesha-antonov, thanks for spending the time on this and sorry for the late reply. You are right in saying that the problem is with Private headers rather than public ones. I'm so confused because building for Release works properly but Archive fails... and AFAIK, the archive command will first build for release and the create the package... so, it is very unclear and weird that one works and the other doesn't... :/ |
As a workaround, while we investigate this issue, I think we can move forward with this fix (I verified too that it works). |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thanks for the explanation. Didn't look at the logs there I hope that Apple will fix it if it's Xcode's |
Summary: Hi When I tried to archive macos catalyst app in Xcode I got errors: <img width="977" alt="Screenshot 2024-02-05 at 00 03 32" src="https://github.com/kesha-antonov/react-native/assets/11584712/b83f75a5-b42f-42e4-9afa-1e2527501baa"> This PR fixes archiving by linking PrivateHeaders in yoga.framework <img width="399" alt="Screenshot 2024-02-05 at 01 03 48" src="https://github.com/kesha-antonov/react-native/assets/11584712/089080ad-b1dc-4703-9273-d8aa3253205e"> <img width="1404" alt="Screenshot 2024-02-05 at 01 05 18" src="https://github.com/kesha-antonov/react-native/assets/11584712/5263cb80-8a53-4a51-bcfc-9d3a2ba739b4"> Prev PR here facebook/react-native#42159 ## Changelog: [IOS] [FIXED] - fixed archiving for Mac Catalyst X-link: facebook/react-native#42847 Reviewed By: NickGerleman Differential Revision: D53920474 Pulled By: cipolleschi fbshipit-source-id: 0534d9aa9d249e4e0c35ada0464c38c291be7f84
This pull request was successfully merged by @kesha-antonov in 767330f. When will my fix make it into a release? | Upcoming Releases |
Summary: Hi When I tried to archive macos catalyst app in Xcode I got errors: <img width="977" alt="Screenshot 2024-02-05 at 00 03 32" src="https://github.com/kesha-antonov/react-native/assets/11584712/b83f75a5-b42f-42e4-9afa-1e2527501baa"> This PR fixes archiving by linking PrivateHeaders in yoga.framework <img width="399" alt="Screenshot 2024-02-05 at 01 03 48" src="https://github.com/kesha-antonov/react-native/assets/11584712/089080ad-b1dc-4703-9273-d8aa3253205e"> <img width="1404" alt="Screenshot 2024-02-05 at 01 05 18" src="https://github.com/kesha-antonov/react-native/assets/11584712/5263cb80-8a53-4a51-bcfc-9d3a2ba739b4"> Prev PR here facebook/react-native#42159 ## Changelog: [IOS] [FIXED] - fixed archiving for Mac Catalyst X-link: facebook/react-native#42847 Reviewed By: NickGerleman Differential Revision: D53920474 Pulled By: cipolleschi fbshipit-source-id: 0534d9aa9d249e4e0c35ada0464c38c291be7f84
Hi
Summary:
When I tried to archive macos catalyst app in Xcode I got errors:
This PR fixes archiving by linking PrivateHeaders in yoga.framework
Prev PR here #42159
Changelog:
[IOS] [FIXED] - fixed archiving for Mac Catalyst
Test Plan:
Try archive react-native tester app for macos catalyst in Xcode