Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS] Fix race condition between A11yManager and UIManager #42382

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jan 19, 2024

Summary:

Community reported a race condition when 0.73 apps are built in Release mode. What happens is that there is a deadlock between the accessibility manager and the UIManager.

This PR fixes the deadlock by moving the accessibility manager lazy initialization.

Changelog:

[Internal] - Fixed deadlock at startup

Test Plan:

Tested in a 0.73 app

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 19, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable January 19, 2024 12:55
@analysis-bot
Copy link

analysis-bot commented Jan 19, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,499,846 -8,298,965
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,754,365 -10,431,642
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fd0ca4d
Branch: main

@cipolleschi cipolleschi marked this pull request as ready for review January 19, 2024 15:40
@cipolleschi cipolleschi force-pushed the cipolleschi/fix_new_arch_release branch from 38abcf3 to f39f34e Compare January 19, 2024 15:51
@blakef blakef merged commit e476db2 into 0.73-stable Jan 25, 2024
64 checks passed
@blakef blakef deleted the cipolleschi/fix_new_arch_release branch January 25, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants