Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: ReactHost: Remove new prefix from task creation methods #42169

Closed
wants to merge 5 commits into from
Closed

Refactor: ReactHost: Remove new prefix from task creation methods #42169

wants to merge 5 commits into from

Commits on Jan 10, 2024

  1. [skip ci] Refactor: ReactHost: Rename getOrCreateReactInstanceTask ->… 

    … getOrCreateReactInstance

Summary:
This will help avoid a name collision when we remove the new suffix from newGetOrCreateReactInstanceTask.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495532
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f1450d6 View commit details
    Browse the repository at this point in the history

  2. [skip ci] Refactor: ReactHost: Rename {new,old}Start to {new,old}GetO… 

    …rCreateStartTask

Summary: Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495535
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b487c17 View commit details
    Browse the repository at this point in the history

  3. [skip ci] Refactor: ReactHost: Make getOrCreateStartTask confined to … 

    …the ReactHost thread

Summary: Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495534
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8a172bc View commit details
    Browse the repository at this point in the history

  4. [skip ci] Refactor: ReactHost: Delete old task creation methods (face… 

    …book#42168)

Summary:

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495533
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4543968 View commit details
    Browse the repository at this point in the history

  5. Refactor: ReactHost: Remove new prefix from task creation methods (fa… 

    …cebook#42169)

Summary:

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495531
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a6f38fa View commit details
    Browse the repository at this point in the history