Add errata supporting changes to position: static #41130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50506915 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 20, 2023
Summary: X-link: facebook/react-native#41130 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Differential Revision: D50506915 fbshipit-source-id: fcdbed46c07e681376ed19677cf0a40b448da421
Base commit: e5a91d7 |
Summary: X-link: facebook/yoga#1434 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Reviewed By: NickGerleman Differential Revision: D50506915
joevilches
force-pushed
the
export-D50506915
branch
from
aed8beb
to
cbb4d68
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50506915 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 23, 2023
Summary: Pull Request resolved: facebook#1434 X-link: facebook/react-native#41130 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Reviewed By: NickGerleman Differential Revision: D50506915 fbshipit-source-id: 3a72743a30710c64b8eecfe8e08e613f46e62112
|
This pull request was successfully merged by @joevilches in 60297d5. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 24, 2023
Summary: X-link: facebook/yoga#1434 X-link: facebook/react-native#41130 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Reviewed By: NickGerleman Differential Revision: D50506915 fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 24, 2023
Summary: Pull Request resolved: #1434 X-link: facebook/react-native#41130 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Reviewed By: NickGerleman Differential Revision: D50506915 fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/yoga#1434 Pull Request resolved: facebook#41130 I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless. Reviewed By: NickGerleman Differential Revision: D50506915 fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.
Differential Revision: D50506915