Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new arch example not render in RNTester #39810

Closed
wants to merge 1 commit into from
Closed

Fix new arch example not render in RNTester #39810

wants to merge 1 commit into from

Commits on Oct 5, 2023

  1. Fix new arch example not render in RNTester (facebook#39810) 

    Summary:

Two issues will be fixed:
- Bridgeless has lazy view manager loading by default so the React Package that provides view managers must implement ViewManagerOnDemandReactPackage, we might could refactor the design of package classes later
- ThemedReactContext should **NOT** be used directly to call function ```getJSModule```, since it doesn't overrides ```getJSModule``` for Bridgeless, we can use it's internal variable ```meactApplicationContext``` which should be an instance of BridgelessReactContext

Changelog:
[Android][Changed] - Fix new arch example not render in RNTester

Reviewed By: cortinico

Differential Revision: D49912656
    @luluwu2032 @facebook-github-bot
    luluwu2032 authored and facebook-github-bot committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f174a1e View commit details
    Browse the repository at this point in the history