Consider transforms correctly in some of the new DOM layout methods #39349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49069517 |
Base commit: a63b443 |
|
This pull request was exported from Phabricator. Differential Revision: D49069517 |
rubennorte
force-pushed
the
export-D49069517
branch
from
c38bc62
to
7b1d9ab
Compare
Differential Revision: D49020219 fbshipit-source-id: 1736d5f6b9be0c6cb611709f3fb69b3247d953d7
Differential Revision: D49058368 fbshipit-source-id: 3b70ea06768dc5eb0852009688d93885b0b9eac9
Differential Revision: D49069518 fbshipit-source-id: 365be394cfd4ac4129cd03d8939a14966cd6fac2
…acebook#39349) Summary: Pull Request resolved: facebook#39349 This fixes these methods to ignore transforms, as per the spec: * `offsetLeft` * `offsetTop` * `offsetWidth` * `offsetHeight` * `clientLeft` * `clientTop` * `clientWidth` * `clientHeight` `scrollWidth` and `scrollHeight` are the last methods we need to fix, as their fix is more complex than in these cases (in scroll views, the scrollable area is the overflow of all its children with transforms applied, which is an expensive computation we don't currently do, even in host platforms where this behavior doesn't work correctly). Changelog: [internal] Reviewed By: NickGerleman Differential Revision: D49069517 fbshipit-source-id: e320f4b0a9b2c1817916db4f8ec51693f81dc1ff
|
This pull request was exported from Phabricator. Differential Revision: D49069517 |
rubennorte
force-pushed
the
export-D49069517
branch
from
7b1d9ab
to
228602a
Compare
|
This pull request has been merged in 016e4af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes these methods to ignore transforms, as per the spec:
offsetLeftoffsetTopoffsetWidthoffsetHeightclientLeftclientTopclientWidthclientHeightscrollWidthandscrollHeightare the last methods we need to fix, as their fix is more complex than in these cases. I'll do it in a follow-up diff.Changelog: [internal]
Reviewed By: NickGerleman
Differential Revision: D49069517