Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to control flipper with an Env var #39261

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This change allow us to control whether we want to install flipper or not in RNTester using an env var.
This is just a simple quality of life change to speed up local testing.

Changelog:

[Internal] - Allow to control whether to install Flipper or not from an env variable

Differential Revision: D48907743

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48907743

@analysis-bot
Copy link

analysis-bot commented Sep 1, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,963,185 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,757 +3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4bc089a
Branch: main

Summary:

This change allow us to control whether we want to install flipper or not in RNTester using an env var.
This is just a simple quality of life change to speed up local testing.

## Changelog:
[Internal] - Allow to control whether to install Flipper or not from an env variable

Reviewed By: dmytrorykun

Differential Revision: D48907743
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48907743

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 89dfc08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants