Pass hitSlop into usePressability #38857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
Base commit: a8962ce |
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
el1t
added a commit
to el1t/react-native
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: facebook#38857 `hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present Changelog: [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config Reviewed By: NickGerleman Differential Revision: D48124538 fbshipit-source-id: 1d95259cd0dfd02f3646022d1fe7f4d39e66a9fa
el1t
added a commit
to el1t/react-native
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: facebook#38857 `hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present Changelog: [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config Reviewed By: NickGerleman Differential Revision: D48124538 fbshipit-source-id: 5721da1c8031f7a9e084efbea98f2a1c8840fa4d
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
el1t
added a commit
to el1t/react-native
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: facebook#38857 `hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present Changelog: [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config Reviewed By: NickGerleman Differential Revision: D48124538 fbshipit-source-id: de736df4fa66f423fc647f4c858834f3acd3b386
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
Summary: Pull Request resolved: facebook#38857 `hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present Changelog: [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config Reviewed By: NickGerleman Differential Revision: D48124538 fbshipit-source-id: aca4bed70fed92512bca38632c043160ae0fb974
|
This pull request was exported from Phabricator. Differential Revision: D48124538 |
|
This pull request has been merged in d6ff5c6. |
lunaleaps
pushed a commit
that referenced
this pull request
Aug 10, 2023
Summary: Pull Request resolved: #38857 `hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present Changelog: [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config Reviewed By: NickGerleman Differential Revision: D48124538 fbshipit-source-id: a910fdcec55e67d37c84facca297428556ef777e
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
hitSlopmust be passed into theusePressabilityhook in order for it to take effect. It's a no-op if no hit slop is presentReviewed By: NickGerleman
Differential Revision: D48124538