Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failure on iOS with pnpm and use_frameworks! #38158

Closed
wants to merge 1 commit into from
Closed

Fix build failure on iOS with pnpm and use_frameworks! #38158

wants to merge 1 commit into from

Commits on Jul 3, 2023

  1. Fix build failure on iOS with pnpm and use_frameworks! due to cocoapo… 

    …ds copying symlinked headers to wrong paths

When using pnpm all packages are symlinked to node_modules/.pnpm to prevent phantom dependency resolution. This causes react-native iOS build to fail because Cocoapods copies headers to incorrect destinations when they're behind symlinks. The fix resolves absolute paths to the header_mappings_dir at pod install time. With absolute paths cocoapods copies the headers correctly.

This commit also adds a few missing header search paths in use_frameworks! mode.
    evelant committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    09e1cea View commit details
    Browse the repository at this point in the history