Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix pod install --project-directory=ios failing #37993

Merged
merged 3 commits into from
Jun 23, 2023
Merged

fix(ios): fix pod install --project-directory=ios failing #37993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f59a80e
fix(ios): fix `pod install --project-directory=ios` failing
tido64 Jun 21, 2023
bb81be1
update test
tido64 Jun 21, 2023
116b2c2
fixup! update test
tido64 Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/cocoapods/__tests__/codegen_utils-test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def testUseReactCodegenDiscovery_whenParametersAreGood_executeCodegen
'[Codegen] warn: using experimental new codegen integration'
])
assert_equal(codegen_utils_mock.get_react_codegen_script_phases_params, [{
:app_path => "~/app",
:app_path => app_path,
:config_file_dir => "",
:config_key => "codegenConfig",
:fabric_enabled => false,
Expand All @@ -361,7 +361,7 @@ def testUseReactCodegenDiscovery_whenParametersAreGood_executeCodegen
assert_equal(codegen_utils_mock.get_react_codegen_spec_params, [{
:fabric_enabled => false,
:folly_version=>"2021.07.22.00",
:package_json_file => "../node_modules/react-native/package.json",
:package_json_file => "#{app_path}/ios/../node_modules/react-native/package.json",
:script_phases => "echo TestScript"
}])
assert_equal(codegen_utils_mock.generate_react_codegen_spec_params, [{
Expand Down
2 changes: 1 addition & 1 deletion scripts/cocoapods/codegen_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def use_react_native_codegen_discovery!(
:config_key => config_key
)
react_codegen_spec = codegen_utils.get_react_codegen_spec(
File.join(react_native_path, "package.json"),
File.join(relative_installation_root, react_native_path, "package.json"),
:folly_version => folly_version,
:fabric_enabled => fabric_enabled,
:hermes_enabled => hermes_enabled,
Expand Down