Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide unnecessarily exposed private methods in GlobalPerformanceLogger #37947

Closed
wants to merge 1 commit into from
Closed

Hide unnecessarily exposed private methods in GlobalPerformanceLogger #37947

wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Jun 17, 2023

Summary:

Changelog:

[Internal] -

This is a follow-up to an earlier change, that inadvertently added internal methods as public into the GlobalPerformance API.

Differential Revision: D46820273

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46820273

@analysis-bot
Copy link

analysis-bot commented Jun 17, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,755,927 -39
android hermes armeabi-v7a 8,068,675 -41
android hermes x86 9,249,532 -33
android hermes x86_64 9,097,681 -38
android jsc arm64-v8a 9,317,132 -34
android jsc armeabi-v7a 8,507,212 -21
android jsc x86 9,381,612 -28
android jsc x86_64 9,633,854 -18

Base commit: 53526e7
Branch: main

@rshest @facebook-github-bot
Hide unnecessarily exposed private methods in GlobalPerformanceLogger (…
25635bb 
…facebook#37947)

Summary:
Pull Request resolved: facebook#37947

# Changelog:
[Internal] -

This is a follow-up to an earlier change, that inadvertently added internal methods as public into the GlobalPerformance API.

Reviewed By: rubennorte

Differential Revision: D46820273

fbshipit-source-id: 8835af95af1bbb7bae7f32976bc14769a274d56c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46820273

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in af57ce1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshest @facebook-github-bot @analysis-bot