Convert CompositeReactPackageTest to Kotlin #37734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 08dc0a6 |
cortinico
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks for sending this @MohamedRejeb
Please separate your PRs as you have the changes for TouchEventDispatchTest and FakeLoggingDelegate also included here which should be removed.
I've left some comments that needs to be addressed before we can merge this. Thanks for doing this work.
Comment on lines
124
to
125
| val expected: Set<NativeModule> = HashSet(listOf(moduleNo1, moduleNo3, moduleNo4)) | ||
| val actual: Set<NativeModule> = HashSet(compositeModules) |
There was a problem hiding this comment.
Suggested change
| val expected: Set<NativeModule> = HashSet(listOf(moduleNo1, moduleNo3, moduleNo4)) | |
| val actual: Set<NativeModule> = HashSet(compositeModules) | |
| val expected: Set<NativeModule> = listOf(moduleNo1, moduleNo3, moduleNo4).toSet() | |
| val actual: Set<NativeModule> = compositeModules.toSet() |
Comment on lines
174
to
175
| val expected: Set<ViewManager<*, *>> = HashSet(listOf(managerNo1, managerNo3, managerNo4)) | ||
| val actual: Set<ViewManager<*, *>> = HashSet(compositeModules) |
cortinico
approved these changes
Jun 7, 2023
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 34dd725. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 8, 2023
* main: (1824 commits) Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750) Migrate JSPackagerClientTest to Kotlin (facebook#37747) (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746) Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745) Move flow-typed definitions to repo root (facebook#37636) Convert InterpolatorTypeTest to Kotlin (facebook#37724) Update documentation of ReactHost.reload method (facebook#37691) Reduce visibility of ReactHost.destroy() method (facebook#37693) Reduce visibility in React Context (facebook#37695) Remove InstanceHandleHelper as unused (facebook#37740) Convert CompositeReactPackageTest to Kotlin (facebook#37734) Add license header to SetSpanOperation.java Convert FakeEventDispatcher to kotlin (facebook#37739) Convert FakeRCTEventEmitter to Kotlin (facebook#37733) Convert InteropModuleRegistryTest to Kotlin (facebook#37735) Bump `autorebase.yml` to `v1.8` (facebook#37584) Convert StackTraceHelperTest to Kotlin (facebook#37741) Convert BlobModuleTest class to Kotlin (facebook#37719) Update prettier to v2.8.8 (facebook#37738) Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744) ... # Conflicts: # BUCK # packages/react-native/React/Views/UIResponder+FirstResponder.h # packages/react-native/React/Views/UIResponder+FirstResponder.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Converts CompositeReactPackageTest from Java to Kotlin, as per issue #37708
Changelog:
[Internal] [Changed] - Convert CompositeReactPackageTest to Kotlin
Test Plan:
Tests pass:
./gradlew :packages:react-native:ReactAndroid:testFormatted with KtFmt