Fixing line truncation issue when numberOfLines = {1} #37667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
arushikesarwani94
force-pushed
the
export-D46175963
branch
from
094df98
to
958700a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46175963 |
Summary: Pull Request resolved: facebook#37667 Changelog: [Android][Fixed] - Fixing line truncation issue in Text containing /n when numberOfLines = {1} When the text has multiple lines (with new line characters \n to hard-break the lines), and the first line is short enough to fit, Text component with `numberOfLines = {1}` doesn't display "..." at the end and rather disrespects the /n character. With `numberOfLines = {1}`, On iOS it translates to `line 1`, on Android & Web it translates to `line 1 line 2...` **Expected Behavior :** `line 1...` Reviewed By: javache, NickGerleman Differential Revision: D46175963 fbshipit-source-id: 75db6df1d8b749a168630b6be29bf80f479a4db1
|
This pull request was exported from Phabricator. Differential Revision: D46175963 |
arushikesarwani94
force-pushed
the
export-D46175963
branch
from
958700a
to
c0ef24b
Compare
|
This pull request has been merged in 0af806e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android][Fixed] - Fixing line truncation issue in Text containing /n when numberOfLines = {1}
When the text has multiple lines (with new line characters \n to hard-break the lines), and the first line is short enough to fit, Text component with
numberOfLines = {1}doesn't display "..." at the end and rather disrespects the /n character.With
numberOfLines = {1}, On iOS it translates toline 1, on Android & Web it translates toline 1 line 2...Expected Behavior :
line 1...Reviewed By: NickGerleman
Differential Revision: D46175963