Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce RCTHostCreationHelpers #37328

Closed
wants to merge 2 commits into from
Closed

Conversation

philIip
Copy link
Contributor

@philIip philIip commented May 9, 2023

Summary:
Changelog: [Internal]
in this diff, i introduced a C function to be used to create RCTHost that obfuscates away all the C++ arguments. i expect this to be the API that the vast majority of the community will use to create RCTHost.

Differential Revision: D45678970

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45678970

@analysis-bot
Copy link

analysis-bot commented May 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,722,339 +0
android hermes armeabi-v7a 8,033,174 -2
android hermes x86 9,209,416 -3
android hermes x86_64 9,063,752 -2
android jsc arm64-v8a 9,286,971 +0
android jsc armeabi-v7a 8,475,234 +0
android jsc x86 9,345,433 -1
android jsc x86_64 9,603,367 -1

Base commit: 93ce461
Branch: main

philIip and others added 2 commits May 9, 2023 15:58
Differential Revision: D45678969

fbshipit-source-id: fd3d79d03dcb385ebf97a483cbab782201b69bda
Summary:
Pull Request resolved: facebook#37328

Changelog: [Internal]
in this diff, i introduced a C function to be used to create RCTHost that obfuscates away all the C++ arguments. i expect this to be the API that the vast majority of the community will use to create `RCTHost`.

Differential Revision: D45678970

fbshipit-source-id: e0597d35664788ec3b91a8d5987d78ef6ceab3d7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45678970

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a320dce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants