Fix Flipper by moving FB_SONARKIT_ENABLED to RCTAppDelegate #37240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 6d886a8 |
cipolleschi
approved these changes
May 4, 2023
There was a problem hiding this comment.
@djMax Thank you for taking care of this (and sorry for this misstep on our side... 🤦)
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Life goals! Happy to be able contribute, even if it's tiny. |
|
@cipolleschi merged this pull request in 34d5212. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…#37240) Summary: An out-of-the-box react-native init project no longer enables Flipper properly as of 0.72.0-rc1. ## Changelog: [IOS] [FIXED] Fix Flipper by moving podfile modification of preprocessor def `FB_SONARKIT_ENABLED` from React-Core to React-RCTAppDelegate where it is now used. Pull Request resolved: facebook#37240 Test Plan: Generated an app and verified Flipper cannot see the app. Made the modification and generated another app and verified Flipper now sees it and can enable plugins. Verified that runtime (non-test) use of FB_SONARKIT_ENABLED is limited to Libraries/AppDelegate in this project. Reviewed By: dmytrorykun Differential Revision: D45563282 Pulled By: cipolleschi fbshipit-source-id: d760c5ae123cc7c967b19c6c626801d6db28d052
kelset
pushed a commit
that referenced
this pull request
May 10, 2023
Summary: An out-of-the-box react-native init project no longer enables Flipper properly as of 0.72.0-rc1. ## Changelog: [IOS] [FIXED] Fix Flipper by moving podfile modification of preprocessor def `FB_SONARKIT_ENABLED` from React-Core to React-RCTAppDelegate where it is now used. Pull Request resolved: #37240 Test Plan: Generated an app and verified Flipper cannot see the app. Made the modification and generated another app and verified Flipper now sees it and can enable plugins. Verified that runtime (non-test) use of FB_SONARKIT_ENABLED is limited to Libraries/AppDelegate in this project. Reviewed By: dmytrorykun Differential Revision: D45563282 Pulled By: cipolleschi fbshipit-source-id: d760c5ae123cc7c967b19c6c626801d6db28d052
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
An out-of-the-box react-native init project no longer enables Flipper properly as of 0.72.0-rc1.
Changelog:
[IOS] [FIXED] Fix Flipper by moving podfile modification of preprocessor def
FB_SONARKIT_ENABLEDfrom React-Core to React-RCTAppDelegate where it is now used.Test Plan:
Generated an app and verified Flipper cannot see the app. Made the modification and generated another app and verified Flipper now sees it and can enable plugins. Verified that runtime (non-test) use of FB_SONARKIT_ENABLED is limited to Libraries/AppDelegate in this project.