Remove duplicate function prototype #37194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45483572 |
Base commit: 042179a |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#37194 `convertObjCObjectToJSIValue` function prototype is declared in `RCTTurboModule.h`. This diff removes its duplicate declaration from `RCTTurboModule.m`. Changelog: [Interanal] Differential Revision: D45483572 fbshipit-source-id: a290f55523f07c1fe5c9a5dd488c199c3d012c26
dmytrorykun
force-pushed
the
export-D45483572
branch
from
16b5947
to
3e81924
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45483572 |
Summary: Pull Request resolved: facebook#37194 `convertObjCObjectToJSIValue` function prototype is declared in `RCTTurboModule.h`. This diff removes its duplicate declaration from `RCTTurboModule.m`. Changelog: [Interanal] Reviewed By: cipolleschi Differential Revision: D45483572 fbshipit-source-id: 077dd030c369ef9f515332d69e0404dfc67a18ed
|
This pull request was exported from Phabricator. Differential Revision: D45483572 |
dmytrorykun
force-pushed
the
export-D45483572
branch
from
3e81924
to
4dae9b6
Compare
|
This pull request has been merged in bffb307. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37194 `convertObjCObjectToJSIValue` function prototype is declared in `RCTTurboModule.h`. This diff removes its duplicate declaration from `RCTTurboModule.m`. Changelog: [Interanal] Reviewed By: cipolleschi Differential Revision: D45483572 fbshipit-source-id: bc1edae7e08b5345281134ebfe9d0cbdfedcf581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
convertObjCObjectToJSIValuefunction prototype is declared inRCTTurboModule.h. This diff removes its duplicate declaration fromRCTTurboModule.m.Changelog: [Interanal]
Differential Revision: D45483572