Replace 'React' with 'react' in rntester examples #37185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45445211 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2023
This patches the ASAN RNTester example (which is RNTester specific) to import from 'react' instead of 'React'. There are two other RNTester modules that import from 'React' (ActivityIndicatorExample and CrashExample) that will get fixed once react-native-macos syncs past facebook#37185.
4 tasks
Base commit: 4568e8f |
Saadnajmi
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
May 1, 2023
This patches the ASAN RNTester example (which is RNTester specific) to import from 'react' instead of 'React'. There are two other RNTester modules that import from 'React' (ActivityIndicatorExample and CrashExample) that will get fixed once react-native-macos syncs past facebook#37185. Co-authored-by: Eric Rozell <ericroz@meta.com>
|
This pull request was exported from Phabricator. Differential Revision: D45445211 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2023
Summary: React Native macOS: Please note, I do not plan to Pull Request resolved: facebook#37185 Updates a few imports in RNTester to 'react' as we had previously done in: facebook@0ee5f689 Changelog: [Internal] Differential Revision: D45445211 fbshipit-source-id: 4a672d1ebc486dc32f54aa378852ab5dd676a1b1
|
This pull request was exported from Phabricator. Differential Revision: D45445211 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 2, 2023
Summary: React Native macOS: Please note, I do not plan to Pull Request resolved: facebook#37185 Updates a few imports in RNTester to 'react' as we had previously done in: facebook@0ee5f689 Changelog: [Internal] Reviewed By: jacdebug Differential Revision: D45445211 fbshipit-source-id: 9d6708c16193a60e6dfa31d17900f8c6ebbfdcd0
Summary: React Native macOS: Please note, I do not plan to Pull Request resolved: facebook#37185 Updates a few imports in RNTester to 'react' as we had previously done in: facebook@0ee5f689 Changelog: [Internal] Reviewed By: jacdebug Differential Revision: D45445211 fbshipit-source-id: b44353d6f3a2b8ead076626226052c7a15e1b7ff
|
This pull request was exported from Phabricator. Differential Revision: D45445211 |
|
This pull request has been merged in 042179a. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: React Native macOS: Please note, I do not plan to Pull Request resolved: facebook#37185 Updates a few imports in RNTester to 'react' as we had previously done in: facebook@0ee5f689 Changelog: [Internal] Reviewed By: jacdebug Differential Revision: D45445211 fbshipit-source-id: 7d345a874bd8b99ddb11ebb5385c2a07330a6531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates a few imports in RNTester to 'react' as we had previously done in:
0ee5f689
Differential Revision: D45445211