Remove use of JSI_EXPORT from codegen #37085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45274824 |
Base commit: 03a4de9 |
Summary: Pull Request resolved: facebook#37085 changelog: [internal] Props and event emitter does not need to use JSI_EXPORT. Therefore we can remove include of jsi.h as well. Reviewed By: cortinico, rshest Differential Revision: D45274824 fbshipit-source-id: b6b93958e2958d2b5c0f002792c2a62e24d4e43e
|
This pull request was exported from Phabricator. Differential Revision: D45274824 |
sammy-SC
force-pushed
the
export-D45274824
branch
from
638f989
to
54386f1
Compare
|
This pull request has been merged in fc5a7f7. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37085 changelog: [internal] Props and event emitter does not need to use JSI_EXPORT. Therefore we can remove include of jsi.h as well. Reviewed By: cortinico, rshest Differential Revision: D45274824 fbshipit-source-id: dd756258767f787e49d86dc31e18ce581f444362
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37085 changelog: [internal] Props and event emitter does not need to use JSI_EXPORT. Therefore we can remove include of jsi.h as well. Reviewed By: cortinico, rshest Differential Revision: D45274824 fbshipit-source-id: dd756258767f787e49d86dc31e18ce581f444362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Props and event emitter does not need to use JSI_EXPORT. Therefore we can remove include of jsi.h as well.
Reviewed By: rshest
Differential Revision: D45274824