Fix the setup to allow the build-from-source on host projects #36702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
hoxyq
approved these changes
Mar 29, 2023
Base commit: 8eb28e7 |
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 29, 2023
…ok#36702) Summary: Pull Request resolved: facebook#36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 7ff16142c0084885e8185a2916bdbc1401cc44a6
cortinico
force-pushed
the
export-D44502428
branch
from
095109d
to
e63f604
Compare
…ok#36702) Summary: Pull Request resolved: facebook#36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 4e351b45b13370e5c082004bc6567007c57e6ee7
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
cortinico
force-pushed
the
export-D44502428
branch
from
e63f604
to
9af9c50
Compare
|
This pull request has been merged in fec5658. |
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: #36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 3ad8fb114f5e2f7ffdf6fffa617ceaa45334f5f3
@hoxyq Nope I don't think we'll be doing this for now, as those will be exposed to users, and I'm trying to keep the |
|
@cortinico do we need to cherry-pick this in 0.72 branch? |
|
Yup this needs to be backported 👍 |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ok#36702) Summary: Pull Request resolved: facebook#36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 3ad8fb114f5e2f7ffdf6fffa617ceaa45334f5f3
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#36702) Summary: Pull Request resolved: facebook#36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 3ad8fb114f5e2f7ffdf6fffa617ceaa45334f5f3
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With the monorepo changes we broke the build from source for users.
This fixes it so that folks can just follow the guide:
https://reactnative.dev/contributing/how-to-build-from-source
Changelog:
[Android] [Fixed] - Fix the setup to allow the build-from-source on host projects
Differential Revision: D44502428